Fix NDirect methods in multicorejit

[gbalykov]

• Exception can be thrown if native library is not found (this is the case if multicorejit is used with crossgen2, where Internal.JitInterface.CorInfoImpl.jitStartup and Internal.JitInterface.CorInfoImpl.getJit have "clrjitilc" native library, which is subtituted with correct library name during execution of crossgen2)
• Assert _ASSERTE(pModule->IsSystem()) can be hit in AssertMulticoreJitAllowedModule if cctor is triggered at P/Invoke link time (IsClassConstructorTriggeredAtLinkTime()), skip such methods

cc @alpencolt

[ghost]

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

[jkotas]

Exception can be thrown if native library is not found (this is the case if multicorejit is used with crossgen2, where Internal.JitInterface.CorInfoImpl.jitStartup and Internal.JitInterface.CorInfoImpl.getJit have "clrjitilc" native library, which is subtituted with correct library name during execution of crossgen2)

Would it be better to stop resolving the PInvoke targets on the background thread? Resolving the PInvoke targets can have bad side-effect and break applications.

[gbalykov]

@jkotas you mean that exception might happen in GetStubForInteropMethod and leave runtime in incorrect state? Or that even correctly finished GetStubForInteropMethod can lead to problems?

In my other PR #48326 I've disabled NDirect methods. I'll close this PR then.

[jkotas]

Or that even correctly finished GetStubForInteropMethod can lead to problems?

Yes, even correctly finished GetStubForInteropMethod can lead to problems. The application can install callbacks that influence how the PInvoke targets get resolved. GetStubForInteropMethod executed by speculative background JIT can miss these callbacks. The proper fix for this issue would need to disable resolving the PInvoke targets on background thread, and resolved them on the foreground thread instead once the PInvoke method gets actually called.

In my other PR #48326 I've disabled NDirect methods. I'll close this PR then.

Sounds good to me.

[gbalykov]

@jkotas thanks for detailed clarification!