Added tests for LoggerMessage.Define with skipEnabledCheck#50773
Merged
maryamariyan merged 2 commits intodotnet:mainfrom Apr 23, 2021
Merged
Added tests for LoggerMessage.Define with skipEnabledCheck#50773maryamariyan merged 2 commits intodotnet:mainfrom
maryamariyan merged 2 commits intodotnet:mainfrom
Conversation
ghost
added
the
|
Tagging subscribers to this area: @maryamariyan Issue DetailsCf. #50334 (comment) /cc: @maryamariyan
|
maryamariyan
reviewed
Apr 6, 2021
src/libraries/Microsoft.Extensions.Logging/tests/DI.Common/Common/src/TestLogger.cs
Show resolved
Hide resolved
maryamariyan
approved these changes
Apr 6, 2021
Contributor
maryamariyan
left a comment
maryamariyan
left a comment
There was a problem hiding this comment.
LGTM. Thanks @gfoidl
Member
|
Closed and re-opened to kick CI again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cf. #50334 (comment)
/cc: @maryamariyan