-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Update RuntimeTypeMetadataUpdateHandler to be able to clear all caches #51242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
commented
Apr 14, 2021
...lr/System.Private.CoreLib/src/System/Reflection/Metadata/RuntimeTypeMetadataUpdateHandler.cs
Outdated
Show resolved
Hide resolved
pranavkm
reviewed
Apr 14, 2021
...lr/System.Private.CoreLib/src/System/Reflection/Metadata/RuntimeTypeMetadataUpdateHandler.cs
Outdated
Show resolved
Hide resolved
a93f642 to
eb90394
Compare
stephentoub
commented
Apr 14, 2021
...lr/System.Private.CoreLib/src/System/Reflection/Metadata/RuntimeTypeMetadataUpdateHandler.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Apr 14, 2021
...lr/System.Private.CoreLib/src/System/Reflection/Metadata/RuntimeTypeMetadataUpdateHandler.cs
Outdated
Show resolved
Hide resolved
903d895 to
03a59e1
Compare
03a59e1 to
ea417e9
Compare
Contributor
|
Hi @stephentoub . Is my understanding correct that after
the added field should be in the result? |
Member
Author
|
@mikem8361, @tommcdon, the above will need investigation. The RuntimeTypeCache is correctly being cleared, and new methods and properties added with ApplyUpdate are correctly showing up via reflection after an update, but fields are not. |
Contributor
|
Thanks for looking into this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #50938
cc: @mikem8361, @tommcdon, @pranavkm, @lambdageek
Note per our offline conversation, I changed the BeforeUpdate argument to be Type[] instead of Type.