Some small follow up to #50450 #51328
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
Contributor
Author
|
Closing as the original change is being reverted. |
ghost
locked as resolved and limited conversation to collaborators
SingleAccretion
deleted the
Fold-Overflow-Operations-In-Value-Numbering-Followup
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues.targetsCastFromFloatOverflowsinstead ofCastFromDoubleOverflowsingtFoldExprConst. I have apparently missed this one in Handle casts done via helpers and fold overflow operations in value numbering #50450 (they should be functionally equivalent, but the former doesn't require one to think about why is that the case).