Skip to content

Conversation

@carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Apr 19, 2021

Warning caused by xml docs crefs: #49506

src\libraries\System.Formats.Cbor\src\System\Formats\Cbor\Writer\CborWriter.Map.cs(29,79): error SA1121: (NETCORE_ENGINEERING_TELEMETRY=Build) Use built-in type alias

Fixes #51518

@ghost ghost added the area-System.Security label Apr 19, 2021
@ghost
Copy link

ghost commented Apr 19, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

Warning caused by an xml docs cref: #49506

Author: carlossanlop
Assignees: -
Labels:

area-System.Security

Milestone: -

@carlossanlop carlossanlop self-assigned this Apr 19, 2021
@carlossanlop carlossanlop added area-System.Formats.Cbor blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' documentation Documentation bug or enhancement, does not impact product or test code and removed area-System.Security labels Apr 19, 2021
@ghost
Copy link

ghost commented Apr 19, 2021

Tagging subscribers to this area: @eiriktsarpalis, @bartonjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Warning caused by xml docs crefs: #49506

src\libraries\System.Formats.Cbor\src\System\Formats\Cbor\Writer\CborWriter.Map.cs(29,79): error SA1121: (NETCORE_ENGINEERING_TELEMETRY=Build) Use built-in type alias
Author: carlossanlop
Assignees: carlossanlop
Labels:

area-System.Formats.Cbor, blocking-clean-ci, documentation

Milestone: -

@carlossanlop carlossanlop added this to the 6.0.0 milestone Apr 19, 2021
@carlossanlop carlossanlop requested a review from bartonjs April 19, 2021 19:39
@joperezr
Copy link
Member

Since this is fixing a build break in CI, should we just go ahead and merge?

@joperezr
Copy link
Member

I'll go ahead and merge this to unblock all of the rest of the PRs going in. If there is any additional feedback here I'll address in a follow up PR.

@joperezr joperezr merged commit acff8f3 into dotnet:main Apr 19, 2021
@carlossanlop carlossanlop deleted the cbordocs branch April 19, 2021 20:19
@ghost ghost locked as resolved and limited conversation to collaborators May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Formats.Cbor blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' documentation Documentation bug or enhancement, does not impact product or test code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI warning SA1121: Use built-in type alias

4 participants