Improve arguments handling in build-runtime.cmd #51639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @hoyosjs Issue DetailsThis change in #49906 broke official NativeAOT builds, because the
|
jkoritzinsky
approved these changes
Apr 21, 2021
Member
Author
|
Filed #51655 for the failed sorting tests. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change in #49906 broke official NativeAOT builds, because the
-componentarguments after/p:OfficialBuildId=valueare not recognized by thebuild-runtime.cmdscript. In contrast to the Linux version,build-runtime.cmdstops processing arguments after the first unrecognized one. This PR removes that difference and allows specifying MSBuild properties at any place in the command line.