Skip to content

Dead end S.Security.Cryptography.Cng package #51853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ViktorHofer merged 6 commits into from
Apr 26, 2021
Merged

Dead end S.Security.Cryptography.Cng package #51853

ViktorHofer merged 6 commits into from
Apr 26, 2021

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Apr 26, 2021 •
edited
Loading

To reduce complexity of the cryptography cng library, dead ending its
package as most of the configurations are partial facades anyway and
adding Cng to the targeting pack. It's already part of the runtime and
exposed in aspnetcore's targeting pack. Note that the Platform
Analyzer will discourage the usage of these APIs on unsupported
platforms.

.NET Standard libraries can continue to use the latest available package
which harvests for .NET Standard configurations.

Contributes to #47530

@ViktorHofer ViktorHofer added area-Infrastructure-libraries breaking-change Issue or PR that represents a breaking API or functional change over a previous release. labels Apr 26, 2021
@ViktorHofer ViktorHofer added this to the 6.0.0 milestone Apr 26, 2021
@ViktorHofer ViktorHofer requested review from bartonjs and ericstj April 26, 2021 10:24
@ViktorHofer ViktorHofer self-assigned this Apr 26, 2021
@ghost ghost added needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet new-api-needs-documentation labels Apr 26, 2021
@ghost
Copy link

ghost commented Apr 26, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

To reduce complexity of the cryptography cng library, dead ending its
package as most of the configurations are partial facades anyway and
adding Cng to the targeting pack. It's already part of the runtime and
exposed in aspnetcore's targeting pack.

.NET Standard libraries can continue to use the latest available package
which harvests for .NET Standard configurations.

Contributes to #47530

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries, breaking-change
Milestone: 6.0.0

@ViktorHofer
Dead end S.Security.Cryptography.Cng package
c25b78d 
To reduce complexity of the cryptography cng library, dead ending its
package as most of the configurations are partial facades anyway and
adding Cng to the targeting pack. It's already part of the runtime and
exposed in aspnetcore's targeting pack.

.NET Standard libraries can continue to use the latest available package
which harvests for .NET Standard configurations.

Contributes to dotnet#47530
@ViktorHofer ViktorHofer force-pushed the cryptopackage-deadend branch from 193a58a to c25b78d Compare April 26, 2021 10:25
@dotnet dotnet deleted a comment Apr 26, 2021
@ghost
Copy link

ghost commented Apr 26, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

To reduce complexity of the cryptography cng library, dead ending its
package as most of the configurations are partial facades anyway and
adding Cng to the targeting pack. It's already part of the runtime and
exposed in aspnetcore's targeting pack.

.NET Standard libraries can continue to use the latest available package
which harvests for .NET Standard configurations.

Contributes to #47530

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-System.Security, breaking-change, needs-breaking-change-doc-created
Milestone: 6.0.0

@ViktorHofer ViktorHofer mentioned this pull request Apr 26, 2021
Closed
25 tasks
ericstj
ericstj approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo any cleanup @bartonjs might want to do.

@ViktorHofer ViktorHofer merged commit ac82799 into dotnet:main Apr 26, 2021
@ViktorHofer ViktorHofer deleted the cryptopackage-deadend branch April 26, 2021 21:38
@eerhardt eerhardt mentioned this pull request Apr 27, 2021
Closed
This was referenced May 24, 2021
Merged
Merged
@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2021
@ViktorHofer ViktorHofer removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ericstj ericstj ericstj approved these changes

@bartonjs bartonjs bartonjs approved these changes

@safern safern safern approved these changes

Assignees

@ViktorHofer ViktorHofer

Labels

area-System.Security breaking-change Issue or PR that represents a breaking API or functional change over a previous release.

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ViktorHofer @ericstj @bartonjs @safern