Skip to content

[wasm] Add comments with linker fixes made for running aot tests in #52006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
radical merged 2 commits into from
Jun 1, 2021
Merged

[wasm] Add comments with linker fixes made for running aot tests in #52006

radical merged 2 commits into from
Jun 1, 2021

Conversation

@radical
Copy link
Member

@radical radical commented Apr 28, 2021

.. #51697 .

@radical radical added arch-wasm WebAssembly architecture area-Build-mono trimming-for-aot `EnableAggressiveTrimming=true` used for running tests with AOT labels Apr 28, 2021
@ghost
Copy link

ghost commented Apr 28, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

.. #51697 .

Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono, trimming-for-aot
Milestone: -

@radical radical requested a review from lewing April 28, 2021 20:12
@radical radical requested a review from lewing April 29, 2021 22:59
@steveisok steveisok self-requested a review May 31, 2021 11:53
@radical radical merged commit 024a727 into dotnet:main Jun 1, 2021
@radical radical deleted the aot-xml-links branch June 1, 2021 16:33
@ghost ghost locked as resolved and limited conversation to collaborators Jul 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radekdoulik radekdoulik radekdoulik left review comments

@steveisok steveisok steveisok approved these changes

@eiriktsarpalis eiriktsarpalis Awaiting requested review from eiriktsarpalis

@jozkee jozkee Awaiting requested review from jozkee

@layomia layomia Awaiting requested review from layomia

@steveharter steveharter Awaiting requested review from steveharter

@lewing lewing Awaiting requested review from lewing

Assignees

No one assigned

Labels

arch-wasm WebAssembly architecture area-Build-mono trimming-for-aot `EnableAggressiveTrimming=true` used for running tests with AOT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@radical @lewing @steveisok @radekdoulik