Skip to content

Fix for failing WebSocket deflate test on ARM #52052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarnaViire merged 1 commit into from
May 11, 2021
Merged

Fix for failing WebSocket deflate test on ARM #52052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/libraries/System.Net.WebSockets/tests/WebSocketDeflateTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,12 +421,6 @@ public async Task ReceiveInvalidCompressedData()
[MemberData(nameof(SupportedWindowBits))]
public async Task PayloadShouldHaveSimilarSizeWhenSplitIntoSegments(int windowBits)
{
if (PlatformDetection.IsArmOrArm64Process && (windowBits == 14 || windowBits == 15))
{
// https://github.com/dotnet/runtime/issues/52031
return;
}

MemoryStream stream = new();
using WebSocket client = WebSocket.CreateFromStream(stream, new WebSocketCreationOptions
{
Expand All @@ -440,11 +434,11 @@ public async Task PayloadShouldHaveSimilarSizeWhenSplitIntoSegments(int windowBi
int frameSize = 2 << windowBits;

byte[] message = new byte[frameSize * 10];
Random random = new(0);
new Random(0).NextBytes(message);

for (int i = 0; i < message.Length; ++i)
{
message[i] = (byte)random.Next(maxValue: 10);
message[i] %= 10;
}

await client.SendAsync(message, WebSocketMessageType.Binary, true, CancellationToken);
Expand Down