Skip to content

Move Logging Generator and attribute to Logging.Abstractions #52256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maryamariyan merged 2 commits into from
May 5, 2021
Merged

Move Logging Generator and attribute to Logging.Abstractions #52256

maryamariyan merged 2 commits into from
May 5, 2021
+11 −11

Conversation

@maryamariyan
Copy link
Contributor

@maryamariyan maryamariyan commented May 4, 2021 •
edited
Loading

  • Pending API Approval.

Fixes: #52222

@ghost
Copy link

ghost commented May 4, 2021

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@maryamariyan maryamariyan self-assigned this May 4, 2021
@ghost
Copy link

ghost commented May 4, 2021

Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Pending API Approval.

Fixes: #52222

Author: maryamariyan
Assignees: -
Labels:

area-Extensions-Logging, new-api-needs-documentation
Milestone: -

@ericstj
Copy link
Member

ericstj commented May 4, 2021

Make sure you change this reference:

runtime/src/libraries/Microsoft.Extensions.Logging/tests/Microsoft.Extensions.Logging.Generators.Tests/Microsoft.Extensions.Logging.Generators.Tests.csproj

Line 16 in 9e685b2

<ProjectReference Include="$(LibrariesProjectRoot)Microsoft.Extensions.Logging\src\Microsoft.Extensions.Logging.csproj" />

@maryamariyan maryamariyan marked this pull request as ready for review May 4, 2021 22:41
ericstj
ericstj reviewed May 5, 2021
View reviewed changes
...rosoft.Extensions.Logging.Abstractions/pkg/Microsoft.Extensions.Logging.Abstractions.pkgproj
<ProjectReference Include="..\src\Microsoft.Extensions.Logging.Abstractions.csproj">
<SupportedFramework>net461;netcoreapp2.0;uap10.0.16299;$(AllXamarinFrameworks)</SupportedFramework>
</ProjectReference>
<ProjectReference Include="..\gen\Microsoft.Extensions.Logging.Generators.csproj" />
Copy link
Member

@ericstj ericstj May 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will conflict with #52084 cc @Anipik

eerhardt
eerhardt approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@maryamariyan maryamariyan merged commit d058930 into dotnet:main May 5, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eerhardt eerhardt eerhardt approved these changes

@ericstj ericstj ericstj approved these changes

@davidfowl davidfowl Awaiting requested review from davidfowl

Assignees

@maryamariyan maryamariyan

Labels

area-Extensions-Logging new-api-needs-documentation

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

Move Logging Source Generator to MS.Extensions.Logging.Abstractions

4 participants

@maryamariyan @ericstj @eerhardt @karelz