[wasm] Fix Emscripten SDK provisioning for tests #52273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue Details
Fixes #52254 .
|
Member
Author
|
hm I'll try to move this closer to helix bits |
- For running on AOT tests on helix, we need to send emsdk as a payload
- On the CI machines, emscripten is available in `/usr/local/emscripten/`
- but the helix tasks try to write a `.payload` file in that dir, which fails
because of permissions
- So, we copy emsdk to local `src/mono/wasm/emsdk`
- But we were doing it as part of *every* test build!
- this meant unncessarily copying, and races causing errors like:
```
/__w/1/s/eng/testing/tests.wasm.targets(138,5):
error MSB3026: Could not copy "/usr/local/emscripten/emsdk/node/14.15.5_64bit/bin/node" to "/__w/1/s/src/mono/wasm/emsdk/node/14.15.5_64bit/bin/node".
Beginning retry 1 in 1000ms. The process cannot access the file '/__w/1/s/src/mono/wasm/emsdk/node/14.15.5_64bit/bin/node' because it is being used by another process. [/__w/1/s/src/libraries/System.Collections.Specialized/tests/System.Collections.Specialized.Tests.csproj]
```
- Instead, do that once when preparing work items for helix
Fixes dotnet#52254 .
radical
force-pushed
the
fix-emsdk-provision
branch
from
2ad5c45 to
e6163a0
Compare
lewing
approved these changes
May 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For running on AOT tests on helix, we need to send emsdk as a payload
On the CI machines, emscripten is available in
/usr/local/emscripten/but the helix tasks try to write a
.payloadfile in that dir, which failsbecause of permissions
So, we copy emsdk to local
src/mono/wasm/emsdkBut we were doing it as part of every test build!
pretestFixes #52254 .