[wasm][debugger] Reuse debugger-agent on wasm debugger #52300

thaystg · 2021-05-05T14:15:38Z

This will remove a lot of code that does the same thing on mini-wasm-debugger.

The code for debugger before this PR was shared between mini-wasm-debugger, library_mono.js and the BrowserDebugProxy. With this new approach the important code for the debugger are mainly on debugger-agent and BrowserDebugProxy.

This PR affects the size of dotnet.wasm and dotnet.js as is described below.

	without PR	with PR	bytes	%
dotnet.js	249786	225242	24544	9,83%	REDUCED
dotnet.wasm	2277406	2299707	22300	0,98%	INCREASED
brotli dotnet.js	52291	47638	4653	8,90%	REDUCED
brotli dotnet.wasm	780756	793778	13022	1,67%	INCREASED

…ot of code that does the same thing on mini-wasm-debugger.

ghost · 2021-05-05T14:15:48Z

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

PROTOTYPE!!!
This will remove a lot of code that does the same thing on mini-wasm-debugger.

Author:	thaystg
Assignees:	-
Labels:	`area-Debugger-mono`
Milestone:	-

…debugger-agent and remove unused code.

lewing

Sharing this code will be a great step forward and the prototype is coming along nicely. Nice work.

make -C src/mono/wasm/ run-debugger-tests TEST_FILTER=DebuggerTests.SteppingTests.InspectValueTypeMethodArgsWhileStepping is working without use_cfo.

Failed: 271, Passed: 220

radical

Just posting some comments on the bits that I was able to look at (very little!).

radical · 2021-05-12T16:12:42Z

src/mono/mono/mini/debugger-agent.c

+		for (i = strlen (lookup_name) - 1; i >= 0; --i) {
+			if (lookup_name [i] == '.') {
+				lookup_name [i] = 0;
+				break;
+			}
+		}


can we use strrchr here?

I copied this code from mini-wasm-debugger. Probably yes.

src/mono/mono/mini/debugger-agent.c

radical · 2021-05-12T16:17:18Z

src/mono/mono/mini/debugger-agent.c

+			buffer_add_int(buf, -1);
+			break;
+		}
+		mono_assembly_name_free_internal (aname);


this should be done in the error cases too.

src/mono/mono/mini/debugger-agent.c

radical · 2021-05-12T16:34:50Z

src/mono/mono/mini/debugger-agent.c

+		MonoTypeNameFormat format = MONO_TYPE_NAME_FORMAT_FULL_NAME;
+		if (CHECK_PROTOCOL_VERSION(2, 61))
+			format = (MonoTypeNameFormat) decode_int (p, &p, end);


Would it make sense to make this a macro, or function, so the protocol version stuff doesn't have to be here?

radical · 2021-05-12T16:39:55Z

src/mono/mono/mini/debugger-agent.c

 }

+ErrorCode
+mono_process_dbg_packet (int id, CommandSet command_set, int command, gboolean *no_reply, guint8 *p, guint8 *end, Buffer *buf)


Maybe rename p to something descriptive

radical · 2021-05-13T16:36:46Z

src/mono/mono/mini/debugger-agent.c

-	/* Enums are sent as a normal vtype */
-	if (is_enum)
-		return ERR_NOT_IMPLEMENTED;
+	if (CHECK_PROTOCOL_VERSION(2, 61))
+		decode_byte (buf, &buf, limit);


What happens in versions other than 2.61 now?

Implementing handling error on debugger-agent.

Failed: 248, Passed: 243

Failed: 243, Passed: 248

Failed: 226, Passed: 265

Failed: 192, Passed: 299

Failed: 184, Passed: 307

…oints tests are passing. Failed: 172, Passed: 319

Failed: 156, Passed: 335

Failed: 148, Passed: 343

Failed: 99, Passed: 392

Failed: 53, Passed: 438

Failed: 31, Passed: 460

Failed: 30, Passed: 461

lewing

This is looking great but I have some style questions while I keep reviewing. There are a few small formatting things to fix as well but I stopped pointing them out individually.

src/mono/mono/mini/debugger-agent.c

src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs

src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs

Co-authored-by: Larry Ewing <lewing@microsoft.com>

lewing

More style thoughts, but feel free to ignore

src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs

src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs

src/mono/wasm/debugger/DebuggerTestSuite/SteppingTests.cs

src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs

Co-authored-by: Larry Ewing <lewing@microsoft.com>

filipnavara · 2021-06-17T06:15:16Z

The amount of this error in the Helix logs is worrying:
/__w/1/s/src/mono/mono/metadata/mono-hash.c:282: assertion 'hash != NULL' failed
(eg. https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-52300-merge-bf5b213642ce4e2dae/System.Runtime.Extensions.Tests/console.cd1b4bde.log?sv=2019-07-07&se=2021-07-07T03%3A41%3A46Z&sr=c&sp=rl&sig=nnN1S1pF0TwQdFeeCEwGR15Fivujlty4Gl4wTHGmgiY%3D)

thaystg · 2021-06-17T06:47:27Z

Thanks @filipnavara I'll take a look! :)

lewing

Let's do a lot of manual testing now.

cc @radical @pavelsavara @radekdoulik @kg @Daniel-Genkin-MS

Daniel-Genkin · 2021-06-22T22:15:19Z

I just did some testing on Windows and found the following behaviours. Although I'm not sure if they are directly applicable to this PR. Although other than that, this works really well and is really cool!!

if you hover your mouse over the html tags in the elements tab of chrome's devtools then the debugger's log prints the following error:
fail: Microsoft.WebAssembly.Diagnostics.DevToolsProxy[0] sending error response for id: msg-:::180 -> [Result: IsOk: False, IsErr: True, Value: , Error: { "code": -32000, "message": "Could not compute box model." } ]
if you "Deactivate all breakpoints" and refresh the page being debugged the breakpoints set in the native code are lost. So when you enable them, the breakpoints aren't re-added. However if you manually disable all the breakpoints, they aren't lost upon page refreshes.
when cancelling the debugger via CTRL + C, it prints an error stack trace to the debugger's log
fail: Microsoft.WebAssembly.Diagnostics.DevToolsProxy[0] DevToolsProxy::Run: Exception System.AggregateException: One or more errors occurred. (A task was canceled.) ---> System.Threading.Tasks.TaskCanceledException: A task was canceled. at System.Threading.Tasks.Task.GetExceptions(Boolean includeTaskCanceledExceptions) at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions) at System.Threading.Tasks.Task1.GetResultCore(Boolean waitCompletionNotification) at Microsoft.WebAssembly.Diagnostics.DevToolsProxy.Run(Uri browserUri, WebSocket ideSocket) in C:\runtime\src\mono\wasm\debugger\BrowserDebugProxy\DevToolsProxy.cs:line 283 at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread) at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining) at System.Threading.Tasks.Task.RunContinuations(Object continuationObject) at System.Threading.Tasks.Task1.TrySetResult(TResult result) at System.Threading.Tasks.TaskFactory.CompleteOnInvokePromise.Invoke(Task completingTask) at System.Threading.Tasks.Task.RunContinuations(Object continuationObject) at System.Threading.Tasks.Task.CancellationCleanupLogic() at System.Threading.Tasks.Task.TrySetCanceled(CancellationToken tokenToRecord, Object cancellationException) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.SetException(Exception exception, Task1& taskField) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.SetException(Exception exception) at Microsoft.WebAssembly.Diagnostics.DevToolsProxy.ReadOne(WebSocket socket, CancellationToken token) in C:\runtime\src\mono\wasm\debugger\BrowserDebugProxy\DevToolsProxy.cs:line 61 at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread) at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining) at System.Threading.Tasks.Task.RunContinuations(Object continuationObject) at System.Threading.Tasks.Task.CancellationCleanupLogic() at System.Threading.Tasks.Task.TrySetCanceled(CancellationToken tokenToRecord, Object cancellationException) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.SetException(Exception exception, Task1& taskField) at System.Runtime.CompilerServices.AsyncValueTaskMethodBuilder1.SetException(Exception exception) at System.Net.WebSockets.ManagedWebSocket.ReceiveAsyncPrivate[TWebSocketReceiveResultGetter,TWebSocketReceiveResult](Memory1 payloadBuffer, CancellationToken cancellationToken, TWebSocketReceiveResultGetter resultGetter) at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread) at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining) at System.Threading.Tasks.Task.RunContinuations(Object continuationObject) at System.Threading.Tasks.Task.CancellationCleanupLogic() at System.Threading.Tasks.Task.TrySetCanceled(CancellationToken tokenToRecord, Object cancellationException) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.SetException(Exception exception, Task1& taskField) at System.Runtime.CompilerServices.AsyncValueTaskMethodBuilder.SetException(Exception exception) at System.Net.WebSockets.ManagedWebSocket.EnsureBufferContainsAsync(Int32 minimumRequiredBytes, CancellationToken cancellationToken, Boolean throwOnPrematureClosure) at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread) at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining) at System.Threading.Tasks.Task.RunContinuations(Object continuationObject) at System.Threading.Tasks.Task.CancellationCleanupLogic() at System.Threading.Tasks.Task.TrySetCanceled(CancellationToken tokenToRecord, Object cancellationException) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.SetException(Exception exception, Task1& taskField) at System.Runtime.CompilerServices.AsyncValueTaskMethodBuilder1.SetException(Exception exception) at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpRequestStream.ReadAsyncInternal(Memory1 destination, CancellationToken cancellationToken) at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread) at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining) at System.Threading.Tasks.Task.RunContinuations(Object continuationObject) at System.Threading.Tasks.Task.CancellationCleanupLogic() at System.Threading.Tasks.Task.TrySetCanceled(CancellationToken tokenToRecord, Object cancellationException) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.SetException(Exception exception, Task1& taskField) at System.Runtime.CompilerServices.AsyncValueTaskMethodBuilder1.SetException(Exception exception) at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.Http1UpgradeMessageBody.ReadAsyncInternalAwaited(ValueTask1 readTask, CancellationToken cancellationToken) at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread) at System.Threading.ThreadPoolWorkQueue.Dispatch() at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart() --- End of stack trace from previous location --- --- End of inner exception stack trace --- at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions) at System.Threading.Tasks.Task1.GetResultCore(Boolean waitCompletionNotification) at Microsoft.WebAssembly.Diagnostics.DevToolsProxy.Run(Uri browserUri, WebSocket ideSocket) in C:\runtime\src\mono\wasm\debugger\BrowserDebugProxy\DevToolsProxy.cs:line 283 Terminate batch job (Y/N)?

lewing · 2021-06-23T05:27:03Z

@Daniel-Genkin thank you for the testing

I just did some testing on Windows and found the following behaviours. Although I'm not sure if they are directly applicable to this PR. Although other than that, this works really well and is really cool!!

if you hover your mouse over the html tags in the elements tab of chrome's devtools then the debugger's log prints the following error:
fail: Microsoft.WebAssembly.Diagnostics.DevToolsProxy[0] sending error response for id: msg-:::180 -> [Result: IsOk: False, IsErr: True, Value: , Error: { "code": -32000, "message": "Could not compute box model." } ]

This needs to have a test added and needs to be fixed. I'm not sure I consider it blocking for landing this pr, especially if it only diagnostics and doesn't surface to the UI.

if you "Deactivate all breakpoints" and refresh the page being debugged the breakpoints set in the native code are lost. So when you enable them, the breakpoints aren't re-added. However if you manually disable all the breakpoints, they aren't lost upon page refreshes.

This sounds like #54040

thaystg · 2021-06-23T12:17:52Z

if you hover your mouse over the html tags in the elements tab of chrome's devtools then the debugger's log prints the following error:
fail: Microsoft.WebAssembly.Diagnostics.DevToolsProxy[0] sending error response for id: msg-:::180 -> [Result: IsOk: False, IsErr: True, Value: , Error: { "code": -32000, "message": "Could not compute box model." } ]

This also happens in the version without my changes, we need to investigate if debugger proxy is returning this error or the browser is returning this error.

thaystg · 2021-06-23T12:20:27Z

when cancelling the debugger via CTRL + C, it prints an error stack trace to the debugger's log
fail: Microsoft.WebAssembly.Diagnostics.DevToolsProxy[0] DevToolsProxy::Run: Exception System.AggregateException: One or more errors occurred. (A task was canceled.) ---> System.Threading.Tasks.TaskCanceledException: A task was canceled. at System.Threading.Tasks.Task.GetExceptions(Boolean includeTaskCanceledExceptions) at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions) at System.Threading.Tasks.Task1.GetResultCore(Boolean waitCompletionNotification) at Microsoft.WebAssembly.Diagnostics.DevToolsProxy.Run(Uri browserUri, WebSocket ideSocket) in C:\runtime\src\mono\wasm\debugger\BrowserDebugProxy\DevToolsProxy.cs:line 283 at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread) at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining) at System.Threading.Tasks.Task.RunContinuations(Object continuationObject) at System.Threading.Tasks.Task1.TrySetResult(TResult result) at System.Threading.Tasks.TaskFactory.CompleteOnInvokePromise.Invoke(Task completingTask) at System.Threading.Tasks.Task.RunContinuations(Object continuationObject) at System.Threading.Tasks.Task.CancellationCleanupLogic() at System.Threading.Tasks.Task.TrySetCanceled(CancellationToken tokenToRecord, Object cancellationException) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.SetException(Exception exception, Task1& taskField) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.SetException(Exception exception) at Microsoft.WebAssembly.Diagnostics.DevToolsProxy.ReadOne(WebSocket socket, CancellationToken token) in C:\runtime\src\mono\wasm\debugger\BrowserDebugProxy\DevToolsProxy.cs:line 61 at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread) at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining) at System.Threading.Tasks.Task.RunContinuations(Object continuationObject) at System.Threading.Tasks.Task.CancellationCleanupLogic() at System.Threading.Tasks.Task.TrySetCanceled(CancellationToken tokenToRecord, Object cancellationException) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.SetException(Exception exception, Task1& taskField) at System.Runtime.CompilerServices.AsyncValueTaskMethodBuilder1.SetException(Exception exception) at System.Net.WebSockets.ManagedWebSocket.ReceiveAsyncPrivate[TWebSocketReceiveResultGetter,TWebSocketReceiveResult](Memory1 payloadBuffer, CancellationToken cancellationToken, TWebSocketReceiveResultGetter resultGetter) at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread) at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining) at System.Threading.Tasks.Task.RunContinuations(Object continuationObject) at System.Threading.Tasks.Task.CancellationCleanupLogic() at System.Threading.Tasks.Task.TrySetCanceled(CancellationToken tokenToRecord, Object cancellationException) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.SetException(Exception exception, Task1& taskField) at System.Runtime.CompilerServices.AsyncValueTaskMethodBuilder.SetException(Exception exception) at System.Net.WebSockets.ManagedWebSocket.EnsureBufferContainsAsync(Int32 minimumRequiredBytes, CancellationToken cancellationToken, Boolean throwOnPrematureClosure) at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread) at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining) at System.Threading.Tasks.Task.RunContinuations(Object continuationObject) at System.Threading.Tasks.Task.CancellationCleanupLogic() at System.Threading.Tasks.Task.TrySetCanceled(CancellationToken tokenToRecord, Object cancellationException) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.SetException(Exception exception, Task1& taskField) at System.Runtime.CompilerServices.AsyncValueTaskMethodBuilder1.SetException(Exception exception) at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpRequestStream.ReadAsyncInternal(Memory1 destination, CancellationToken cancellationToken) at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread) at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining) at System.Threading.Tasks.Task.RunContinuations(Object continuationObject) at System.Threading.Tasks.Task.CancellationCleanupLogic() at System.Threading.Tasks.Task.TrySetCanceled(CancellationToken tokenToRecord, Object cancellationException) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.SetException(Exception exception, Task1& taskField) at System.Runtime.CompilerServices.AsyncValueTaskMethodBuilder1.SetException(Exception exception) at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.Http1UpgradeMessageBody.ReadAsyncInternalAwaited(ValueTask1 readTask, CancellationToken cancellationToken) at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread) at System.Threading.ThreadPoolWorkQueue.Dispatch() at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart() --- End of stack trace from previous location --- --- End of inner exception stack trace --- at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions) at System.Threading.Tasks.Task1.GetResultCore(Boolean waitCompletionNotification) at Microsoft.WebAssembly.Diagnostics.DevToolsProxy.Run(Uri browserUri, WebSocket ideSocket) in C:\runtime\src\mono\wasm\debugger\BrowserDebugProxy\DevToolsProxy.cs:line 283 Terminate batch job (Y/N)?

This one I think that always happens without my changes, but probably we should also try to fix.

thaystg · 2021-06-23T12:20:49Z

@Daniel-Genkin thanks for testing!!! :)

thaystg · 2021-06-23T23:06:45Z

Please, if anyone find anything, please comment here and I will fix and change what is suggested in another PR.
Thanks a lot!

Trying to reuse debugger-agent on wasm debugger. This will remove a l…

7d8de9c

…ot of code that does the same thing on mini-wasm-debugger.

ghost added the area-Debugger-mono label May 5, 2021

thaystg added 4 commits May 5, 2021 15:41

Replace remove_breakpoint and clear_all_breakpoints with the ones on …

8be82ed

…debugger-agent and remove unused code.

Stepping and callstack using debugger-agent.

1fa738d

Remove more code.

f97cf27

Get frame values using debugger-agent.

0242f6a

lewing reviewed May 7, 2021

View reviewed changes

thaystg added 6 commits May 11, 2021 00:20

Working valuetypes and call function on valuetypes.

adae934

make -C src/mono/wasm/ run-debugger-tests TEST_FILTER=DebuggerTests.SteppingTests.InspectValueTypeMethodArgsWhileStepping is working without use_cfo.

Failed: 316, Passed: 175

1f620dc

Failed: 307, Passed: 184, Skipped: 0, Total: 491

4bf5e0c

Failed: 280, Passed: 211

c853b1b

Failed: 277, Passed: 214

372157a

Implemented boxed value.

d837444

Failed: 271, Passed: 220

radical reviewed May 13, 2021

View reviewed changes

thaystg added 15 commits May 14, 2021 09:22

Implementing get properties on objects.

07ff48a

Implementing handling error on debugger-agent.

Implementing callfunctionon object.

6585dce

Failed: 248, Passed: 243

Implementing get pointer values.

adbe8de

Failed: 243, Passed: 248

Fixing pointer values and implement call on function with pointers.

7be985c

Failed: 226, Passed: 265

Reimplement call function on, and implement set values.

8f88612

Failed: 192, Passed: 299

Failed: 192, Passed: 299

478016d

Fixing valuetype with null values.

50d657e

Failed: 184, Passed: 307

Implemented Evaluate expressions, conditional breakpoints, all breakp…

212c081

…oints tests are passing. Failed: 172, Passed: 319

Fixing evaluate with value type.

7186b98

Failed: 156, Passed: 335

Trim part and add cache.

26cf882

Failed: 148, Passed: 343

Fixing evaluate expression.

a8f98b5

Failed: 99, Passed: 392

GetPropertiesTests working.

4010546

Failed: 53, Passed: 438

Passing delegate tests.

fb323d0

Failed: 31, Passed: 460

Removing unused code.

380e6dd

Implementing exception handler.

0712ae1

Failed: 30, Passed: 461

thaystg requested review from SamMonoRT, lambdageek, marek-safar and vargaz as code owners June 2, 2021 18:40

Fix error on wasm build.

67723dc

lewing reviewed Jun 10, 2021

View reviewed changes

thaystg and others added 5 commits June 11, 2021 16:43

Apply suggestions from code review

00a459e

Co-authored-by: Larry Ewing <lewing@microsoft.com>

Changing what was suggested by @lewing.

d3abbf2

Fix pointer tests.

c4c9fa3

Refactoring CreateJObjectForVariableValue

fc8ec74

Changing what @lewing suggested.

62b15f8

lewing reviewed Jun 17, 2021

View reviewed changes

thaystg and others added 4 commits June 17, 2021 00:01

Apply suggestions from code review

f797f9e

Co-authored-by: Larry Ewing <lewing@microsoft.com>

Update src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs

5b2994d

Co-authored-by: Larry Ewing <lewing@microsoft.com>

Update src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs

d4f1d87

Co-authored-by: Larry Ewing <lewing@microsoft.com>

Fixing @lewing changes.

6645cc5

Trying to fix CI.

a61f75e

lewing approved these changes Jun 22, 2021

View reviewed changes

thaystg merged commit 4f4f0db into dotnet:main Jun 23, 2021

ghost locked as resolved and limited conversation to collaborators Jul 24, 2021

[wasm][debugger] Reuse debugger-agent on wasm debugger #52300

[wasm][debugger] Reuse debugger-agent on wasm debugger #52300

Uh oh!

Conversation

thaystg commented May 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented May 5, 2021

Uh oh!

lewing left a comment

Choose a reason for hiding this comment

Uh oh!

radical left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lewing left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lewing left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

filipnavara commented Jun 17, 2021

Uh oh!

thaystg commented Jun 17, 2021

Uh oh!

lewing left a comment

Choose a reason for hiding this comment

Uh oh!

Daniel-Genkin commented Jun 22, 2021

Uh oh!

lewing commented Jun 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thaystg commented Jun 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thaystg commented Jun 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thaystg commented Jun 23, 2021

Uh oh!

thaystg commented Jun 23, 2021

Uh oh!

Reviewers

Assignees

Labels

thaystg commented May 5, 2021 •

edited

Loading

lewing left a comment •

edited

Loading

lewing commented Jun 23, 2021 •

edited

Loading

thaystg commented Jun 23, 2021 •

edited

Loading

thaystg commented Jun 23, 2021 •

edited

Loading