Removing some linker warnings that are no longer needed#52457
Merged
3 commits merged intodotnet:mainfrom May 12, 2021
Merged
Conversation
joperezr
added
the
linkable-framework
|
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer |
ghost
added
the
eerhardt
reviewed
May 7, 2021
eerhardt
approved these changes
May 7, 2021
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
This is awesome we can remove this many warning suppressions! Let's merge this and delete code.
Separately, we should see what we can do to remove that last IL2008 suppression.
eerhardt
reviewed
May 8, 2021
Member
|
If this completely removes all warnings from non-Windows builds we should resolve #40336 and also revert the changes made in dotnet/sdk#16979. That work is at least partially tracked by dotnet/linker#1973. |
marek-safar
reviewed
May 10, 2021
marek-safar
approved these changes
May 10, 2021
|
Hello @joperezr! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Member
Author
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
merged commit 
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @eerhardt
This will need to be rebased with #52272 once that is merged, but sending this in the meantime to test against the CI platform matrix to ensure the other warnings aren't required any longer.