Use more reliable WaitForEventCountersAsync in caching test #52488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Ha ha. Crossed streams. I just followed the same approach and submitted a similar PR a short bit ago before seeing this in my inbox. I'm going to close this PR in favor of the other one (#52490) since that uses a polling criteria that is little more specific to this case. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52464
The simple delay is a race condition that keeps getting hit.
For all such tests in networking we used this approach for waiting on counters. For example HTTP telemetry:
runtime/src/libraries/System.Net.Http/tests/FunctionalTests/TelemetryTest.cs
Line 664 in 187f3b9