Remove unnecessary Dispose Override from BackgroundWorker

[johnthcall]

As part of #43852 this Dispose was missing documentation, however as this is the same as the Dispose(boolean) of Component base class removing this should cause the documentation to be inherited just like Dispose() and GetService(Type) is.

[ghost]

Tagging subscribers to this area: @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

---

As part of #43852 this Dispose was missing documentation, however as this is the same as the Dispose(boolean) of Component base class removing this should cause the documentation to be inherited just like Dispose() and GetService(Type) is.

Author:	johnthcall
Assignees:	-
Labels:	area-System.ComponentModel
Milestone:	-

[KalleOlaviNiemitalo]

Component.Dispose(bool) removes the component from its container, and raises the Disposed event:

runtime/src/libraries/System.ComponentModel.Primitives/src/System/ComponentModel/Component.cs

Lines 80 to 93 in 236cb21

	protected virtual void Dispose(bool disposing)
	{
	if (disposing)
	{
	lock (this)
	{
	_site?.Container?.Remove(this);
	if (_events != null)
	{
	((EventHandler?)_events[s_eventDisposed])?.Invoke(this, EventArgs.Empty);
	}
	}
	}
	}

BackgroundWorker.Dispose(bool disposing) neither calls base.Dispose(disposing) nor does the same things on its own. If you remove that override, then those things will happen when a BackgroundWorker is disposed. Which may be an improvement but anyway increases the risk from the change.

The empty BackgroundWorker.Dispose(bool) method was changed from virtual to override in dotnet/corefx#12324 when Component was added as a base class. In .NET Framework though, BackgroundWorker overrides neither Dispose() nor Dispose(bool), and thus lets Component.Dispose(bool) do its thing.

So, removing the override makes sense to me. However:

• Is that a breaking change if an app defines a class based on BackgroundWorker and calls base.Dispose(disposed)?
• Do the other classes that were changed in the same pull request have Dispose(bool) overrides that prevent Component.Dispose(bool) from working? The missing base.Dispose call was apparently added to FileSystemWatcher in Add missing FileSystemWatcher methods corefx#13656, but it may still be missing from Process.

[johnthcall]

@KalleOlaviNiemitalo thanks for the catch, I had gone to definition of Component but was incorrectly looking at the Decompiled source where it showed no code in the Dispose method.