Test ios tvos simulator functional tests #52655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue Details
|
mdh1418
force-pushed
the
test_ios_tvos_simulator_functional_tests
branch
from
6616e04 to
81df5d4
Compare
Contributor
|
RE linking failure, modify the conditionals in src/tasks/AotCompilerTask/MonoAotCompiler.props to cover tvOS. The 'static' is essential. |
steveisok
approved these changes
May 13, 2021
Member
steveisok
left a comment
steveisok
left a comment
There was a problem hiding this comment.
Looks good. There are some failing iOS tests that we should investigate, but they seem unrelated to this PR.
Member
Author
|
Took note of the iOS failing tests, they didn't produce a |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to #52606 with this suggestion #52606 (comment), this PR re-enables the
iOS.Simulator.Aot.Test.csprojto be ran on CI becauseMonoForceInterpretercan be modified to befalsewhen it is added toTreatAsLocalProperty.Originally, an error along the lines of
MonoForceInterpreter cannot be modified as it is a global propertycaused theiOS.Simulator.Aot.Test.csprojto fail. With the changes in this PR, the functional test project had passed in a previous build run https://helix.dot.net/api/jobs/67f9e21f-0d40-4c73-952e-e272dc167092/workitems/iOS.Simulator.Aot.Test?api-version=2019-06-17Fixes #50589