Skip to content

Rename Mac Catalyst dylib to libmonosgen, not libcoreclr #53038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marek-safar merged 1 commit into from
May 21, 2021
Merged

Rename Mac Catalyst dylib to libmonosgen, not libcoreclr #53038

marek-safar merged 1 commit into from
May 21, 2021

Conversation

@directhex
Copy link
Contributor

@directhex directhex commented May 20, 2021

Fixes #52989

unzip -lf artifacts/packages/Debug/Shipping/Microsoft.NETCore.App.Runtime.Mono.maccatalyst-x64.6.0.0-dev.nupkg | grep dylib$
 10650360  05-20-2021 18:11   runtimes/maccatalyst-x64/native/libmonosgen-2.0.dylib
  1414080  05-20-2021 18:12   runtimes/maccatalyst-x64/native/libSystem.IO.Compression.Native.dylib
   193064  05-20-2021 18:12   runtimes/maccatalyst-x64/native/libSystem.Native.dylib
    55856  05-20-2021 18:12   runtimes/maccatalyst-x64/native/libSystem.Net.Security.Native.dylib
   114528  05-20-2021 18:12   runtimes/maccatalyst-x64/native/libSystem.Security.Cryptography.Native.Apple.dylib

@directhex directhex requested a review from rolfbjarne May 20, 2021 18:27
@directhex directhex requested a review from marek-safar as a code owner May 20, 2021 18:27
@marek-safar marek-safar merged commit b18be1e into dotnet:main May 21, 2021
@akoeplinger
Copy link
Member

akoeplinger commented May 21, 2021

/backport to release/6.0-preview5

@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2021

Started backporting to release/6.0-preview5: https://github.com/dotnet/runtime/actions/runs/863711341

@github-actions github-actions bot mentioned this pull request May 21, 2021
Merged
@runfoapp runfoapp bot mentioned this pull request Jun 2, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@marek-safar marek-safar marek-safar approved these changes

Assignees

No one assigned

Labels

area-Build-mono os-maccatalyst MacCatalyst OS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The MacCatalyst MonoVM runtime packs don't contain a dynamic libmonosgen-2.0.dylib

4 participants

@directhex @akoeplinger @rolfbjarne @marek-safar