Skip to content

Conversation

@elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented May 24, 2021

These look like leftovers from how Framework did IJW.

cc @AaronRobinsonMSFT @jkoritzinsky

@elinor-fung elinor-fung marked this pull request as ready for review May 24, 2021 20:50
@AaronRobinsonMSFT
Copy link
Member

@dotnet/dotnet-diag-contrib for debug/ changes.

@hoyosjs
Copy link
Member

hoyosjs commented May 24, 2021

@dotnet/dotnet-diag

Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know nidump is dead code itself, so all good : )

@elinor-fung elinor-fung merged commit ccdc7e1 into dotnet:main May 25, 2021
@elinor-fung elinor-fung deleted the ijwCleanup branch May 25, 2021 16:06
@elinor-fung
Copy link
Member Author

nidump is dead code itself

Wait, what - as in we could actually delete NativeImageDumper and have DumpNativeImages just not do anything / be not impl?

@AaronRobinsonMSFT
Copy link
Member

As far as I know nidump is dead code itself, so all good : )

@noahfalk Heads up, you've told the interop team there is dead code... there is going to be a race to delete it.

@sdmaclea
Copy link
Contributor

@AaronRobinsonMSFT We discussed lasted night that all fragile ngen specific code was dead since 3.1. We were wondering why it wasn't deleted.

@jkoritzinsky
Copy link
Member

Last I heard, Samsung was continuing to use it in 3.1 after we disabled it. @gbalykov is Tizen still using fragile NGen, or has Tizen moved to large version bubble crossgen2?

@gbalykov
Copy link
Member

cc @alpencolt

@davmason
Copy link
Contributor

@jkotas @davidwrighton is there a reason we haven't deleted everything under FEATURE_PREJIT? I did a quick grep of src\coreclr and don't find anything that defines it any more.

@hoyosjs
Copy link
Member

hoyosjs commented May 25, 2021

I asked Jan earlier today to see if fragile was supported as a customer scenario - even if the framework doesn't ship this way, some customers might use it. However, the answer is no. This is just bits waiting to rot. Prejit will eventually go. Starting with the DAC doesn't sound like a bad idea as it has size impact on singlefile.

@alpencolt
Copy link

We work to bring .NET 6 with R2R Large Version Bubble for Tizen but it still has lower performance comparing to FNV. At the same time there were works to reanimate fragile mode in .NET 6 internally as backup plan.
If we'll choose second way we'll share sources, but would be good if current FNV code will not be deleted until .NET 6 release.

@ghost ghost locked as resolved and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants