Fixed a few issues/assumptions relevant to MCJ recording and playing back R2R'ed code #53198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…back R2R'ed code - Renamed `*wasTier0Jit` to `wasTier0` to include pregenerated code that is loaded, which is considered tier 0 - Added a subset of `FinalizeOptimizationTierForTier0Jit` as `FinalizeOptimizationTierForTier0Load` to set the `wasTier0` flag so that those methods would be call-counted for tiering when MCJ-loaded code is used, and updated the relevant code - Moved recording of loaded method code to after a successful `SetNativeCode()` to prevent duplicate recordings of the same method in multi-threaded races - Enabled `MulticoreJitPrepareCodeConfig` to look up pregenerated code to parallelize that work
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*wasTier0JittowasTier0to include pregenerated code that is loaded, which is considered tier 0FinalizeOptimizationTierForTier0JitasFinalizeOptimizationTierForTier0Loadto set thewasTier0flag so that those methods would be call-counted for tiering when MCJ-loaded code is used, and updated the relevant codeSetNativeCode()to prevent duplicate recordings of the same method in multi-threaded racesMulticoreJitPrepareCodeConfigto look up pregenerated code to parallelize that workIntended to be incorporated into #52595