Skip to content

Removing unnecessary nowarns from trimming tests#53251

Merged
4 commits merged intodotnet:mainfrom
joperezr:trimmingtestcleanup
May 26, 2021
Merged

Removing unnecessary nowarns from trimming tests#53251
4 commits merged intodotnet:mainfrom
joperezr:trimmingtestcleanup

Conversation

@joperezr
Copy link
Copy Markdown
Member

@joperezr joperezr commented May 25, 2021

Fixes #48848

Removing some nowarns that are no longer necessary for running our trimming tests.

@ghost
Copy link
Copy Markdown

ghost commented May 25, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Removing some nowarns that are no longer necessary for running our trimming tests.

Author: joperezr
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@joperezr joperezr added the linkable-framework Issues associated with delivering a linker friendly framework label May 25, 2021
@ghost
Copy link
Copy Markdown

ghost commented May 25, 2021

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer
See info in area-owners.md if you want to be subscribed.

Issue Details

Removing some nowarns that are no longer necessary for running our trimming tests.

Author: joperezr
Assignees: -
Labels:

area-Infrastructure-libraries, linkable-framework

Milestone: -

Comment thread eng/testing/linker/SupportFiles/Directory.Build.targets Outdated
Comment thread eng/testing/linker/project.csproj.template
Copy link
Copy Markdown
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks.

@ghost
Copy link
Copy Markdown

ghost commented May 25, 2021

Hello @joperezr!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 84b7c67 into dotnet:main May 26, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 25, 2021
@joperezr joperezr deleted the trimmingtestcleanup branch April 6, 2022 16:58
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-libraries linkable-framework Issues associated with delivering a linker friendly framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up TrimmingTests infrastructure

3 participants