Skip to content

Conversation

@uweigand
Copy link
Contributor

  • Add dummy support for s390x in vm, jit, debug, and unwinder

  • This suffices to make clr.iltools and clr.paltests buildable

Note to reviewers:

  • When building clr.iltools and/or clr.paltests, the vm/jit/debug/unwinder directories are never actually compiled. However, the cmake process is still executed, so there needs to be enough support for the s390x platform there to avoid cmake aborting (due to missing files or explicit aborts). Let me know if you have any other suggestions on how to enable building just those clr subtargets.

* Add dummy support for s390x in vm, jit, debug, and unwinder

* This suffices to make clr.iltools and clr.paltests buildable
@ghost
Copy link

ghost commented May 26, 2021

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Add dummy support for s390x in vm, jit, debug, and unwinder

  • This suffices to make clr.iltools and clr.paltests buildable

Note to reviewers:

  • When building clr.iltools and/or clr.paltests, the vm/jit/debug/unwinder directories are never actually compiled. However, the cmake process is still executed, so there needs to be enough support for the s390x platform there to avoid cmake aborting (due to missing files or explicit aborts). Let me know if you have any other suggestions on how to enable building just those clr subtargets.
Author: uweigand
Assignees: -
Labels:

area-Infrastructure-coreclr

Milestone: -

@AaronRobinsonMSFT
Copy link
Member

/cc @janvorli

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@marek-safar marek-safar merged commit 54f78b8 into dotnet:main Jun 8, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants