Skip to content

Disable tests for #54007 #54207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BruceForstall merged 1 commit into from
Jun 19, 2021
Merged

Disable tests for #54007 #54207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libraries/System.IO.Hashing/tests/Crc32Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ public void InstanceAppendAllocateAndReset(TestCase testCase)
InstanceAppendAllocateAndResetDriver(testCase);
}

[SkipOnCoreClr("https://github.com/dotnet/runtime/issues/54007", RuntimeConfiguration.Checked)]
Copy link
Member

@safern safern Jun 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI you can go more granular and disable for stress runs but not regular checked runs.

Copy link
Contributor Author

@BruceForstall BruceForstall Jun 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that, but it's any run with optimization (and Checked), so not just stress. Probably should disable also for Debug, but that's rarely used.

[Theory]
[MemberData(nameof(TestCases))]
public void InstanceMultiAppendGetCurrentHash(TestCase testCase)
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.IO.Hashing/tests/Crc64Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ public void InstanceAppendAllocateAndReset(TestCase testCase)
InstanceAppendAllocateAndResetDriver(testCase);
}

[SkipOnCoreClr("https://github.com/dotnet/runtime/issues/54007", RuntimeConfiguration.Checked)]
[Theory]
[MemberData(nameof(TestCases))]
public void InstanceMultiAppendGetCurrentHash(TestCase testCase)
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.IO.Hashing/tests/XxHash32Tests.007.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ public void InstanceAppendAllocateAndReset(TestCase testCase)
InstanceAppendAllocateAndResetDriver(testCase);
}

[SkipOnCoreClr("https://github.com/dotnet/runtime/issues/54007", RuntimeConfiguration.Checked)]
[Theory]
[MemberData(nameof(TestCases))]
public void InstanceMultiAppendGetCurrentHash(TestCase testCase)
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.IO.Hashing/tests/XxHash32Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ public void InstanceAppendAllocateAndReset(TestCase testCase)
InstanceAppendAllocateAndResetDriver(testCase);
}

[SkipOnCoreClr("https://github.com/dotnet/runtime/issues/54007", RuntimeConfiguration.Checked)]
[Theory]
[MemberData(nameof(TestCases))]
public void InstanceMultiAppendGetCurrentHash(TestCase testCase)
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.IO.Hashing/tests/XxHash32Tests.f00d.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ public void InstanceAppendAllocateAndReset(TestCase testCase)
InstanceAppendAllocateAndResetDriver(testCase);
}

[SkipOnCoreClr("https://github.com/dotnet/runtime/issues/54007", RuntimeConfiguration.Checked)]
[Theory]
[MemberData(nameof(TestCases))]
public void InstanceMultiAppendGetCurrentHash(TestCase testCase)
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.IO.Hashing/tests/XxHash64Tests.007.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ public void InstanceAppendAllocateAndReset(TestCase testCase)
InstanceAppendAllocateAndResetDriver(testCase);
}

[SkipOnCoreClr("https://github.com/dotnet/runtime/issues/54007", RuntimeConfiguration.Checked)]
[Theory]
[MemberData(nameof(TestCases))]
public void InstanceMultiAppendGetCurrentHash(TestCase testCase)
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.IO.Hashing/tests/XxHash64Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ public void InstanceAppendAllocateAndReset(TestCase testCase)
InstanceAppendAllocateAndResetDriver(testCase);
}

[SkipOnCoreClr("https://github.com/dotnet/runtime/issues/54007", RuntimeConfiguration.Checked)]
[Theory]
[MemberData(nameof(TestCases))]
public void InstanceMultiAppendGetCurrentHash(TestCase testCase)
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.IO.Hashing/tests/XxHash64Tests.f00d.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ public void InstanceAppendAllocateAndReset(TestCase testCase)
InstanceAppendAllocateAndResetDriver(testCase);
}

[SkipOnCoreClr("https://github.com/dotnet/runtime/issues/54007", RuntimeConfiguration.Checked)]
[Theory]
[MemberData(nameof(TestCases))]
public void InstanceMultiAppendGetCurrentHash(TestCase testCase)
Expand Down