fix MsQuicStream counting on failure #54249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThis is follow-up on #52800 enabling two more tests #52800 missed.
|
scalablecory
approved these changes
Jun 16, 2021
CarnaViire
approved these changes
Jun 17, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow-up on #52800
When we throw in MsQuicStream, the finalizer would still run and that would call Dispose() and that would try to decrement StreamCount and we may hit Debug.Assert on negative number for stream we never added.
Since the Dispose is already using
_state.ConnectionState?.RemoveStream(this);the fix is to defer assignment ofConnectionStateuntil afterTryAddStreamis successfully finished.enabling two more tests #52800 missed.