Add UnixFilePermissions.xml for Mono AOT compilers #54501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radical
reviewed
Jun 21, 2021
...ler/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.MonoCrossAOT.UnixFilePermissions.xml
Show resolved
Hide resolved
radical
approved these changes
Jun 21, 2021
Member
radical
left a comment
radical
left a comment
There was a problem hiding this comment.
Other than the .exe comment, LGTM!
rolfbjarne
approved these changes
Jun 21, 2021
Member
|
Does this have to be back ported to P6? |
src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.MonoCrossAOT.sfxproj
Outdated
Show resolved
Hide resolved
directhex
pushed a commit
to directhex/emsdk
that referenced
this pull request
Jun 21, 2021
…ot executable by the end user: ``` -rwxr--r-- 1 root wheel 106K May 31 07:30 /usr/local/share/dotnet/packs/Microsoft.NET.Runtime.Emscripten.2.0.12.Sdk.osx-x64/6.0.0-preview.5.21281.1/tools/bin/llc ``` Ref: dotnet/runtime#54501 Ref: dotnet/runtime#53545 Ref: dotnet/sdk#16894 Ref: dotnet/macios#11869 Ref: dotnet/android#6010
Contributor
Author
|
@rolfbjarne good question. I think the answer is "yes", the supporting changes in dotnet/sdk are in P6 |
steveisok
pushed a commit
to steveisok/runtime
that referenced
this pull request
Jun 24, 2021
We introduced Microsoft.NETCore.App.MonoCrossAOT.UnixFilePermissions.xml in dotnet#54501 to make sure the right permissions are set when installing AOT compiler workload packs. We hardcoded the list to include mono-aot-cross, llc, and opt. However, in wasm's case they only have mono-aot-cross. This change makes the xml file a template and only includes mono-aot-cross for browser and all three for the other configurations. Fixes dotnet#54612
lewing
pushed a commit
that referenced
this pull request
Jun 24, 2021
* Fix MonoCrossAOT.UnixFilePermissions for wasm We introduced Microsoft.NETCore.App.MonoCrossAOT.UnixFilePermissions.xml in #54501 to make sure the right permissions are set when installing AOT compiler workload packs. We hardcoded the list to include mono-aot-cross, llc, and opt. However, in wasm's case they only have mono-aot-cross. This change makes the xml file a template and only includes mono-aot-cross for browser and all three for the other configurations. Fixes #54612 * Use property instead of item for the file nodes * Ankit suggestion Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is, mono-aot-cross files installed to a system location via workloads are not executable by the end user:
Ref: #53545
Ref: dotnet/sdk#16894
Ref: dotnet/macios#11869
Ref: dotnet/android#6010