Skip to content

Big-endian fix for DoubleTests.cs:ParsePatterns #54818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marek-safar merged 1 commit into from
Jun 29, 2021
Merged

Big-endian fix for DoubleTests.cs:ParsePatterns #54818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/libraries/System.Runtime/tests/System/DoubleTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System.Collections.Generic;
using System.Globalization;
using System.IO;
using System.Linq;
using Xunit;

#pragma warning disable xUnit1025 // reporting duplicate test cases due to not distinguishing 0.0 from -0.0, NaN from -NaN
Expand Down Expand Up @@ -349,15 +350,12 @@ public static void Parse(string value, NumberStyles style, IFormatProvider provi

internal static string SplitPairs(string input)
{
string[] splitPairs = input.Split('-');
string ret = "";
foreach (var pair in splitPairs)
if (!BitConverter.IsLittleEndian)
{
string reversedPair = Reverse(pair);
ret += reversedPair;
return input.Replace("-", "");
}

return ret;
return string.Concat(input.Split('-').Select(pair => Reverse(pair)));
}

internal static string Reverse(string s)
Expand Down