Skip to content

Preserve necessary type and method #54932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fanyang-mono merged 5 commits into from
Jul 1, 2021
Merged

Preserve necessary type and method #54932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b9bae88
Preserve necessary type and method
fanyang-mono Jun 29, 2021
e67171c
Change the way of getting the type
fanyang-mono Jun 30, 2021
07080e3
Inline the constants
fanyang-mono Jun 30, 2021
2930a28
Enable NonValidated_ValidAndInvalidValues_DictionaryMembersWork
fanyang-mono Jun 30, 2021
2458f3b
Enable TransformStrStrResolver3
fanyang-mono Jun 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions eng/testing/ILLink.Descriptor.xunit.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,10 @@
<namespace fullname="Xunit" />
<namespace fullname="Xunit.Sdk" />
</assembly>
<assembly fullname="xunit.assert">
<type fullname="Xunit.Sdk.AssertEqualityComparer`1">
<method signature="System.Boolean CompareTypedSets(System.Collections.IEnumerable,System.Collections.IEnumerable)" />
</type>
</assembly>
<assembly fullname="xunit.runner.utility.netcoreapp10" />
</linker>
1 change: 0 additions & 1 deletion src/libraries/System.Net.Http/tests/UnitTests/Headers/HttpHeadersTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1501,7 +1501,6 @@ public void NonValidated_SetMultipleValuesOnSingleValueHeader_AllHeaderValuesRet
}
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/53647", TestPlatforms.Browser)]
[Fact]
public void NonValidated_ValidAndInvalidValues_DictionaryMembersWork()
{
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Private.Xml/tests/Xslt/XslCompiledTransformApi/XslCompiledTransform.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3002,7 +3002,6 @@ public void TransformStrStrResolver2(XslInputType xslInputType, ReaderType reade
}

//[Variation("Pass XmlUrlResolver, load style sheet with document function, should resolve during transform", Param = "xmlResolver_document_function.txt")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/51911", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))]
[InlineData("xmlResolver_document_function.txt", XslInputType.Reader, ReaderType.XmlValidatingReader)]
[InlineData("xmlResolver_document_function.txt", XslInputType.URI, ReaderType.XmlValidatingReader)]
[InlineData("xmlResolver_document_function.txt", XslInputType.Navigator, ReaderType.XmlValidatingReader)]
Expand Down
8 changes: 2 additions & 6 deletions ...ntime.InteropServices/tests/System/Runtime/InteropServices/IDispatchImplAttributeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,14 @@ namespace System.Runtime.InteropServices.Tests
{
public class IDispatchImplAttributeTests
{
private const string TypeName = "System.Runtime.InteropServices.IDispatchImplAttribute";
private const string ValueName = "Value";

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50717", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))]
[InlineData(-1)]
[InlineData(0)]
[InlineData(2)]
public void Ctor_ImplTypeShort(short implType)
{
Type type = typeof(HandleCollector).Assembly.GetType(TypeName);
PropertyInfo valueProperty = type.GetProperty(ValueName);
Type type = Type.GetType("System.Runtime.InteropServices.IDispatchImplAttribute, System.Runtime.InteropServices");
PropertyInfo valueProperty = type.GetProperty("Value");
Assert.NotNull(type);
Assert.NotNull(valueProperty);

Expand Down
1 change: 0 additions & 1 deletion ...sts/System.Text.Json.Tests/Serialization/CollectionTests/CollectionTests.Generic.Write.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,6 @@ public static void WritePrimitiveQueueT()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50721", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))]
public static void WriteHashSetTOfHashSetT()
{
HashSet<HashSet<int>> input = new HashSet<HashSet<int>>(new List<HashSet<int>>
Expand Down