Fix race condition caused by updating interface map with exact target #55308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change interface map reading to reliably perform a volatile load (without barrier) - When performing scan for exact interface match/match trhough SpecialMarkerTypeForGenericCasting, be careful to only read the map once and use that value for all comparisons - All other uses of InterfaceMapIterator have been audited, and look to be safe
ghost
added
the
Member
Author
|
/azp run help |
|
No pipelines are associated with this pull request. |
Member
Author
|
@VincentBu I've manually triggered the jit stress runs that were failing that caused you to file #54941. Could you take a look and see if the failures have been fixed by my change? See https://dev.azure.com/dnceng/public/_build/results?buildId=1225928&view=results |
Contributor
I check this run and didn't find the failures. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may fix #54941