fix read abort handling and revert CanRead/CanWrite to previous behavior #55341
Conversation
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsWe are currently throwing OperationCancelledException when the peer aborts our write. We should be throwing QuicStreamAbortedException with the appropriate error code. Also fix mock provider to handle write abort and add test. Also, #54798 changed CanRead/CanWrite behavior to return false when completed or aborted, which broke some tests that rely on CanRead/CanWrite to distinguish between unidirectional and bidirectional streams. Revert the behavior of CanRead/CanWrite to previous behavior -- that is, only change these to false when the object is disposed.
|
geoffkizer
requested review from
CarnaViire,
ManickaP and
wfurt
and removed request for
wfurt
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsWe are currently throwing OperationCancelledException when the peer aborts our write. We should be throwing QuicStreamAbortedException with the appropriate error code. Also fix mock provider to handle write abort and add test. Also, #54798 changed CanRead/CanWrite behavior to return false when completed or aborted, which broke some tests that rely on CanRead/CanWrite to distinguish between unidirectional and bidirectional streams. Revert the behavior of CanRead/CanWrite to previous behavior -- that is, only change these to false when the object is disposed.
|
| { | ||
| await using QuicStream stream = await connection.AcceptStreamAsync(); | ||
|
|
||
| QuicStreamAbortedException ex = await Assert.ThrowsAsync<QuicStreamAbortedException>(() => WriteForever(stream)); |
There was a problem hiding this comment.
We discussed previously that it's good to add .WaitAsync(someReasonableTimeout) to WriteForever-like operations, it would still fail the assertion, but we won't have a hanging test
There was a problem hiding this comment.
RunClientServer has a timeout, so the test won't hang forever.
3 participants
We are currently throwing OperationCancelledException when the peer aborts our write. We should be throwing QuicStreamAbortedException with the appropriate error code. Also fix mock provider to handle write abort and add test.
Also, #54798 changed CanRead/CanWrite behavior to return false when completed or aborted, which broke some tests that rely on CanRead/CanWrite to distinguish between unidirectional and bidirectional streams. Revert the behavior of CanRead/CanWrite to previous behavior -- that is, only change these to false when the object is disposed.