Skip to content

Conversation

@thaystg
Copy link
Member

@thaystg thaystg commented Jul 19, 2021

The case that we would get a different behavior is when we have more than one command being executed in the same line:
var d = TimeSpan.TryParseExact(y, @"ss\.fff", null, out var ts) && x.Contains('S');
When we step over we stop in the same line again, then we need to step over again to go to next line.

NOTE: If we want to backport it to preview7 we also need to backport #55869, otherwise it will break step after hotreload for wasm.

@thaystg thaystg requested a review from lewing July 19, 2021 12:24
@thaystg thaystg requested a review from marek-safar as a code owner July 19, 2021 12:24
@ghost ghost added the area-Debugger-mono label Jul 19, 2021
@ghost
Copy link

ghost commented Jul 19, 2021

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Creating test to close #49143.

Author: thaystg
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

@thaystg thaystg changed the title [wasm][]debugger] Creating test to evaluate ToString() [wasm][debugger] Creating test to evaluate ToString() Jul 19, 2021
@thaystg thaystg marked this pull request as draft July 19, 2021 13:34
@thaystg thaystg changed the title [wasm][debugger] Creating test to evaluate ToString() [wasm][debugger] Fix step over behavior Jul 19, 2021
…ng debugger-libs+mono or coreclr.

Fix error message of evaluate calling methods.
Adding test for dotnet#49142
@thaystg thaystg marked this pull request as ready for review July 19, 2021 17:14
@thaystg thaystg requested a review from radical July 19, 2021 17:14
@thaystg thaystg changed the title [wasm][debugger] Fix step over behavior [wasm][debugger] Fix step behavior Jul 19, 2021
@thaystg thaystg merged commit f85f579 into dotnet:main Jul 21, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

2 participants