Fix for Enum.Format change in behavior between .Net Framework and .Net 5#56261
Conversation
Use InternalFormat when formatting an integer value as an Enum that uses the FlagsAttribute. Fix dotnet#56200
ghost
added
area-System.Runtime
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-runtime Issue DetailsUse InternalFormat when formatting an integer Fix #56200
|
|
|
jeffhandley
left a comment
jeffhandley
left a comment
There was a problem hiding this comment.
Thanks for submitting this fix!
danmoseley
changed the title
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix.
|
@ChrisVicary It looks like you need to sign our Contributor License Agreement; that will need to be completed before we can merge this PR. Please let us know if you have any questions or concerns about signing it. This comment has the links you need to complete that step. |
|
@jeffhandley thanks for letting me know. It shouldn't be a problem, but I'm just waiting for legal approval from my employers. In hindsight I should have done that before submitting the PR, but hopefully it will not take long. |
|
Thanks for the update, @ChrisVicary; no worries at all--totally fine to complete it after your first PR is created. |
danmoseley
added
the
NO-MERGE
|
Marking no merge meantime. But we do want it :) |
|
@jeffhandley I have been approved, and have signed the CLA, sorry for the delay. |
stephentoub
removed
the
NO-MERGE
|
Thank you, @ChrisVicary!! |
|
Thanks for your first contribution, @ChrisVicary - we would welcome other contributions if you are interested. There are many issues open to choose from. |
ghost
locked as resolved and limited conversation to collaborators
5 participants
Use InternalFormat when formatting an integer
value as an Enum that uses the FlagsAttribute.
Fix #56200