[release/6.0-preview7] [mono] Add GC unsafe transition to mono_unhandled_exception #56383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
lambdageek,
thaystg and
vargaz
as code owners
|
Tagging subscribers to this area: |
lambdageek
reviewed
Jul 27, 2021
lambdageek
approved these changes
Jul 27, 2021
Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
github-actions
bot
force-pushed
the
backport/pr-56380-to-release/6.0-preview7
branch
from
29d523a to
49fdb01
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #56380 to release/6.0-preview7
/cc @thaystg
When android is calling mono_unhandled_exception is getting this assert: Cannot transition thread 0x7e452274f8 from STATE_BLOCKING with DO_BLOCKING
Customer Impact
Customer will be able to use UnhandledException event on AppDomain on Android and it will be called correctly.
Testing
Manual test with a repro
Risk
Very low, this transition is already used in other external functions.