Skip to content

Conversation

@alnikola
Copy link
Contributor

@alnikola alnikola commented Aug 2, 2021

The test should have been already fixed by #56552.

Fixes #44352

@ghost ghost added the area-System.Net.Http label Aug 2, 2021
@ghost
Copy link

ghost commented Aug 2, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

The test should have been already fixed by #56552.

Fixes #44352

Author: alnikola
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@alnikola
Copy link
Contributor Author

alnikola commented Aug 2, 2021

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MihaZupan
Copy link
Member

The test is signaling a CancellationToken, shouldn't that prevent a timeout even if the request did end up getting retried before #56552?

@alnikola
Copy link
Contributor Author

alnikola commented Aug 2, 2021

The test is signaling a CancellationToken, shouldn't that prevent a timeout even if the request did end up getting retried before #56552?

It seems to be so, but it wouldn't have hung, if it had worked this way.

@alnikola
Copy link
Contributor Author

alnikola commented Aug 2, 2021

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alnikola alnikola marked this pull request as ready for review August 3, 2021 08:07
@alnikola
Copy link
Contributor Author

alnikola commented Aug 3, 2021

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alnikola alnikola added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 3, 2021
@alnikola alnikola removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 3, 2021
@alnikola
Copy link
Contributor Author

alnikola commented Aug 3, 2021

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alnikola alnikola merged commit 7c8f5fb into main Aug 4, 2021
@alnikola alnikola deleted the alnikola-patch-1 branch August 4, 2021 08:41
@karelz karelz added this to the 6.0.0 milestone Aug 17, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failure: SocketsHttpHandlerTest_Http2.SocketSendQueueFull_RequestCanceled_ThrowsOperationCanceled

5 participants