Move GreaterThan2GBFile_SendsAllBytes to a non-parallel test collection #57946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #57907 Intentionally left out
|
ManickaP
approved these changes
Aug 23, 2021
| // Running all cases of GreaterThan2GBFile_SendsAllBytes in parallel may attempt to allocate Min(ProcessorCount, Subclass_Count) * 2GB of disk space | ||
| // in extreme cases. Some CI machines may run out of disk space if this happens. | ||
| [Collection(nameof(NoParallelTests))] | ||
| public class SendFile_NonParallel<T> : SocketTestHelperBase<T> where T : SocketHelperBase, new() |
| public sealed class SendFile_NonParallel_Apm : SendFile_NonParallel<SocketHelperApm> | ||
| { | ||
| public SendFile_NonParallel_Apm(ITestOutputHelper output) : base(output) { } | ||
| } |
Member
There was a problem hiding this comment.
I assume that SocketHelperCancellableTask and SocketHelperSyncForceNonBlocking are left out on purpose?
I should have read the description first 😄
karelz
approved these changes
Aug 24, 2021
Member
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1161691277 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57907
Intentionally left out
***CancellableTaskand***SyncForceNonBlockingto somewhat counterpart the increased execution time. I don't think we need all the cases for this particular test.