add Http3LoopbackConnection.ShutdownAsync and use in AcceptConnectionAsync

[geoffkizer]

Contributes to #57779

Add a ShutdownAsync method on the HTTP3 loopback connection. This will send a GOAWAY frame to the client and wait for the client to close the connection gracefully. It will also eat connection abort exceptions if the client already has closed the connection.

Use this method in AcceptConnectionAsync, after the user's connection handling code has finished. The intent here is to avoid the kind of data loss seen in #57779. and avoid HTTP3-specific one-offs to reenable tests as in #58041.

Also, some fixes to GetAsync_CancelDuringResponseBodyReceived_Unbuffered_TaskCanceledQuickly to work properly with these changes and clean up some unnecessarily complicated logic.

@ManickaP @CarnaViire

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Contributes to #57779

Add a ShutdownAsync method on the HTTP3 loopback connection. This will send a GOAWAY frame to the client and wait for the client to close the connection gracefully. It will also eat connection abort exceptions if the client already has closed the connection.

Use this method in AcceptConnectionAsync, after the user's connection handling code has finished. The intent here is to avoid the kind of data loss seen in #57779. and avoid HTTP3-specific one-offs to reenable tests as in #58041.

Also, some fixes to GetAsync_CancelDuringResponseBodyReceived_Unbuffered_TaskCanceledQuickly to work properly with these changes and clean up some unnecessarily complicated logic.

@ManickaP @CarnaViire

Author:	geoffkizer
Assignees:	-
Labels:	area-System.Net.Http
Milestone:	-

[geoffkizer]

/azp run runtime-libraries-coreclr outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ManickaP]

I ran this with the re-enabled test from #58041, it works nicely. I'd merge this and than I can merge my PR with just re-enabling the test.

[ManickaP]

We have some failing mock tests:

System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_Finalization_Http3_Mock.IncompleteResponseStream_ResponseDropped_CancelsRequestToServer [FAIL]
      System.TimeoutException : The operation has timed out.
      Stack Trace:
        /_/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Finalization.cs(33,0): at System.Net.Http.Functional.Tests.HttpClientHandler_Finalization_Test.IncompleteResponseStream_ResponseDropped_CancelsRequestToServer()
        --- End of stack trace from previous location ---

Seems relevant.

EDIT: reproduces locally on the current main with this change.

[geoffkizer]

The failure in IncompleteResponseStream_ResponseDropped_CancelsRequestToServer seems to be caused by this: #58234

Since this test is not actually working as intended for HTTP3, I am going to disable it once again.

[geoffkizer]

I've pushed some changes that hopefully resolve all the issues.

(1) Disable IncompleteResponseStream_ResponseDropped_CancelsRequestToServer again because it's actually testing what we want it to, and because this change causes it to fail again. More info: #58234
(2) Simplify the change to GetAsync_CancelDuringResponseBodyReceived_Unbuffered_TaskCanceledQuickly, which should fix the WinHttpHandler failure and minimize possible disruption here in general.

Please take a look.

[geoffkizer]

/azp run runtime-libraries-coreclr outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[geoffkizer]

Even though I reverted the more complicated changes to GetAsync_CancelDuringResponseBodyReceived_Unbuffered_TaskCanceledQuickly, I think these are still worth doing in the long run.

Tracked here: #58238

[ManickaP]

/azp run runtime-libraries-coreclr outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[geoffkizer]

@karelz @ManickaP I believe we want to backport for RC2, right?

[geoffkizer]

/backport to release/6.0

[github-actions]

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1180628641