Skip to content

Conversation

@imhameed
Copy link
Contributor

-disable-fp-elim was removed in LLVM 8 in commit b7cef81fd36c85e52b115b9ed6d1fb92d63781d6.
Also see https://reviews.llvm.org/D56351.

The replacement option, -frame-pointer, is still present in LLVM 11.

Fixes #58112.

`-disable-fp-elim` was removed in LLVM 8 in commit b7cef81fd36c85e52b115b9ed6d1fb92d63781d6.
Also see https://reviews.llvm.org/D56351.

The replacement option, `-frame-pointer`, is still present in LLVM 11.

Fixes dotnet#58112.
@SamMonoRT
Copy link
Member

@marek-safar - this needs to be backported to RC1 and 6.0 branches - if it comes up in any of your meetings

@lambdageek
Copy link
Member

/backport to release/6.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/6.0-rc1: https://github.com/dotnet/runtime/actions/runs/1171271793

@imhameed
Copy link
Contributor Author

I'm going to try to verify that this fixes #58112 by hand. The laptop I'm on is not especially fast and building a fresh main copy of xamarin-macios will take a while.

If someone else already has a working copy of main and would like to test this, you'll need to replace xamarin-macios/builds/downloads/dotnet-sdk-6.0.100-rc.*-osx-x64/packs/Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.ios-arm/6.0.0-rc.*/tools/mono-aot-cross with a copy built by building my branch of dotnet/runtime with ./build.sh mono+libs -os iOS -arch arm -configuration Release /p:MonoAOTEnableLLVM=true. The newly built copy of mono-aot-cross can be found in artifacts/bin/mono/iOS.arm.Release/cross/ios-arm/mono-aot-cross.

@marek-safar
Copy link
Contributor

@imhameed please backport to 6.0 branch and send tactics approval request for RC1

@imhameed
Copy link
Contributor Author

Tested locally; works for me. I can build tests/dotnet/MySingleView for arm.

@imhameed imhameed merged commit 9703660 into dotnet:main Aug 30, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iOS: LLVM fails for ios-arm

6 participants