Revert target framework version change to netcoreapp3.0 when building from VS #584
Conversation
|
@fadimounir sorry for the break here. Can't you just install the 5.0 SDK instead? (locally) |
|
@ViktorHofer I haven't tried installing 5.0. Does that work with VS today? |
|
It should yes, but let me try it first. |
I just tried it. It doesn't work |
| <OutputType>Library</OutputType> | ||
| <AssemblyName>ILCompiler.ReadyToRun</AssemblyName> | ||
| <TargetFramework>$(NetCoreAppCurrent)</TargetFramework> | ||
| <TargetFramework Condition="'$(BuildingInsideVisualStudio)' == 'true'">netcoreapp3.0</TargetFramework> |
There was a problem hiding this comment.
OK, I think the right fix would be to downgrade this project entirely. So to set TargetFramework to netcoreapp3.0 not just for inside VS as it was before. We can upgrade at a late rpoint. Same for crossgen2.
There was a problem hiding this comment.
I actually think it was a good idea when you upgraded it to 5.0, since this is the shipping configuration.
The netcoreapp3.0 is just a temporary internal scenario used by our team, and we can remove it when dotnet5 starts working with VS.
trylek
left a comment
trylek
left a comment
There was a problem hiding this comment.
I'm fine with the change but I would prefer to hear from Viktor that he's fine with whatever we're doing before merging in.
|
I will take a look early tomorrow. We can merge this in and if something points out I will let you know. |
ghost
locked as resolved and limited conversation to collaborators
4 participants
Broken by #445 (cc @ViktorHofer)
Using 3.0 for now enables us to build from VS, which is an important scenario for our team currently
@dotnet/crossgen-contrib