[release/5.0] Add support for variance to IDIC #58672
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58646 to release/5.0
/cc @AaronRobinsonMSFT
Customer Impact
This enables support for variance in an
IDynamicInterfaceCastablescenario. The primary user of this, at present, is C#/WinRT. Without this there can be significant performance impact implementing variance in WinRT collections.The precise impact of this change is difficult to define since it dependent on managed type and the generated source for a particular application. However, a thought experiment to predict potential impact can be done using
IEnumerable<T>. Imagine the case whereTis defined to bestring. The generated C#/WinRT tools generated a projection forIEnumerable<string>of a particular type. Consider the case where a user requestsIEnumerable<object>. Based on the current implementation this would fail becauseIEnumerable<object>is notIEnumerable<string>. What this means is C#/WinRT would now need to dynamically create an additional wrapper, at runtime, to wrap theIEnumerable<string>projection into aIEnumerable<object>. This fix avoids that because it enables the runtime to apply its own variance checks viaIsAssignableTo– which is true based on covariance.Testing
Tests have been added.
Risk
Minimal