Skip to content

Conversation

@MichalStrehovsky
Copy link
Member

No description provided.

@MichalStrehovsky MichalStrehovsky added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 7, 2021
@MichalStrehovsky
Copy link
Member Author

/azp run CoreCLR GCC Product Build Linux x64 checked

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@MichalStrehovsky
Copy link
Member Author

No pipelines are associated with this pull request.

Gee thanks for nothing azure-pipelines

@MichalStrehovsky
Copy link
Member Author

Cool so this still doesn't trigger the GCC leg that was seen as failing in #58744.

@MichalStrehovsky
Copy link
Member Author

Before I close this and seriously consider woodworking as a future career development direction, @dotnet/ncl there's a mildly interesting failure in the WASM legs - because we enable -Werror for CMake's configure checks (on the line that I'm deleting in this pull request), our check for HAVE_SYS_POLL_H always fails on MUSL-based targets - not because there's no poll.h, but because MUSL suggests us to #include <poll.h> instead, like POSIX says and issues a warning (causing us to go the !HAVE_SYS_POLL_H paths instead, because of treating the suggestion as error). Not sure if this has any material impact on the product on MUSL-based targets.

(I do wonder how many other CMake configure checks only fail because there is a warning.)

@MichalStrehovsky
Copy link
Member Author

Using pthread_condattr_setclock is tracked in #58737. Closing.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 8, 2021
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-3 branch July 17, 2022 23:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-libraries NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant