Skip to content

Conversation

@BruceForstall
Copy link
Contributor

No description provided.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 8, 2021
@ghost
Copy link

ghost commented Sep 8, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: BruceForstall
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@BruceForstall
Copy link
Contributor Author

/azp run runtime-coreclr jitstress-isas-x86

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BruceForstall
Copy link
Contributor Author

Well, in addition to the Vector256 failure fixed by #58820, this run found one additional assert and one test failure (I'll open issues tomorrow). Looks like maybe it exceeded some timeout also?

cc @tannergooding

@tannergooding
Copy link
Member

tannergooding commented Sep 9, 2021

Well, in addition to the Vector256 failure fixed by #58820, this run found one additional assert and one test failure (I'll open issues tomorrow

Can we rerun the leg now that #58820 is merged to help reduce noise and see only the remaining failures? (I don't remember if this PR needs to be updated first for it to correctly pick up the fix).

Looks like maybe it exceeded some timeout also?

Its definitely possible as we've had issues here in the past. The hardware intrinsic tests cover a few thousand methods and are largely split by ISA and in some cases, like ARM, we've had to explicitly split this further to ensure the individual test runs are small enough for certain stress modes.

@BruceForstall
Copy link
Contributor Author

Newly opened issues:
#58897
#58899

There's not too much noise, so I'm confident these are the only issues. I'll rerun sometime, but maybe this change is ready to be merged and run weekly. I want to look a little more at why the full set of tests didn't seem to run (timeouts or similar).

@BruceForstall
Copy link
Contributor Author

@dotnet/jit-contrib I propose to expand the runtime-coreclr jitstress-isas-x86 pipeline by running each case with JitStress=1 and JitStress=2. PTAL.

At 8.5 hours, it timed out before running all the stress jobs.
@kunalspathak
Copy link
Contributor

Looks good idea to me.

@BruceForstall
Copy link
Contributor Author

@dotnet/jit-contrib I'm ready to merge this, if someone can approve it.

Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It might be interesting to consider if any of the other stress combinations should be tested (possibly on an even longer outer loop given the cost and likely minimal overall benefit).

@BruceForstall
Copy link
Contributor Author

It might be interesting to consider if any of the other stress combinations should be tested (possibly on an even longer outer loop given the cost and likely minimal overall benefit).

This stress job itself is getting extremely long. I considered splitting it, but didn't want to create new pipelines (which then don't share builds). But it's not clear it's even worth running these stress modes even once a week (during the normal development phase)

@BruceForstall BruceForstall merged commit 4957f62 into dotnet:main Sep 13, 2021
@BruceForstall BruceForstall deleted the AddJitStressToAbiStress branch September 13, 2021 16:57
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants