-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add JitStress=1/2 runs to jitstress-isas-x86 pipeline #58822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JitStress=1/2 runs to jitstress-isas-x86 pipeline #58822
Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT Issue Detailsnull
|
|
/azp run runtime-coreclr jitstress-isas-x86 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Well, in addition to the Vector256 failure fixed by #58820, this run found one additional assert and one test failure (I'll open issues tomorrow). Looks like maybe it exceeded some timeout also? |
Can we rerun the leg now that #58820 is merged to help reduce noise and see only the remaining failures? (I don't remember if this PR needs to be updated first for it to correctly pick up the fix).
Its definitely possible as we've had issues here in the past. The hardware intrinsic tests cover a few thousand methods and are largely split by ISA and in some cases, like ARM, we've had to explicitly split this further to ensure the individual test runs are small enough for certain stress modes. |
|
@dotnet/jit-contrib I propose to expand the |
At 8.5 hours, it timed out before running all the stress jobs.
|
Looks good idea to me. |
|
@dotnet/jit-contrib I'm ready to merge this, if someone can approve it. |
tannergooding
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
It might be interesting to consider if any of the other stress combinations should be tested (possibly on an even longer outer loop given the cost and likely minimal overall benefit).
This stress job itself is getting extremely long. I considered splitting it, but didn't want to create new pipelines (which then don't share builds). But it's not clear it's even worth running these stress modes even once a week (during the normal development phase) |
No description provided.