-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[wasm][debugger] Fix concurrent access to cache. #59412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][debugger] Fix concurrent access to cache. #59412
Conversation
|
Tagging subscribers to this area: @thaystg Issue DetailsPropertiesBinaryReader could be access by more than one thread which was causing starting reading from the wrong position and skip positions.
|
|
/backport to release/6.0-rc2 |
|
Started backporting to release/6.0-rc2: https://github.com/dotnet/runtime/actions/runs/1258807377 |
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsPropertiesBinaryReader could be access by more than one thread which was causing starting reading from the wrong position and skip positions.
|
radical
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
/backport to release/6.0-rc2 |
|
Started backporting to release/6.0-rc2: https://github.com/dotnet/runtime/actions/runs/1259023975 |
PropertiesBinaryReader could be access by more than one thread which was causing starting reading from the wrong position and skip positions.
Added a test case for it.
@lewing I would like to backport to rc2.