Using optimized ILGenerator.Emit function in Dependency Injection #59680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were doing some local optimizations with MSIL’s Stloc and Ldloc, but the very same ones are already present in an override of the ILGenerator.Emit function, so we can remove them. This PR also fixes the use of Ldloca that was generating additional nop operations. fix dotnet#59624
ghost
added
area-Extensions-DependencyInjection
community-contribution
|
Tagging subscribers to this area: @eerhardt, @maryamariyan Issue DetailsWe were doing some local optimizations with MSIL’s Stloc and Ldloc, This PR also fixes the use of Ldloca that was generating additional fix #59624
|
Contributor
Author
|
For reference, ILGenerator.Emit(OpCode, LocalInfo), per @teo-tsirpanis suggestion. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were doing some local optimizations with MSIL’s Stloc and Ldloc, but the very same ones are already present in an override of the ILGenerator.Emit function, so we can remove them.
This PR also fixes the use of Ldloca that was generating additional nop operations.
fix #59624