Fix dependency of GenerateLayout on RestorePackages #60136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parker Bibus pinged me earlier today to report a bug caused by my test cleanup - using generatelayoutonly without previously building the managed tests ends up failing the build due to unrestored packages. This was due to the fact that I overlooked that CopyDependenciesToCoreRoot needs the support projects to be restored; in usual scenarios, they usually got restored as part of another build step like managed test build so that I didn't hit that in my local and lab testing. Thanks Tomas
ghost
added
the
|
Tagging subscribers to this area: @hoyosjs Issue DetailsParker Bibus pinged me earlier today to report a bug caused by my Thanks Tomas /cc @dotnet/runtime-infrastructure
|
jkoritzinsky
approved these changes
Oct 7, 2021
LoopedBard3
approved these changes
Oct 7, 2021
safern
approved these changes
Oct 7, 2021
Member
Author
|
Fixes: #60137 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parker Bibus pinged me earlier today to report a bug caused by my
test cleanup - using generatelayoutonly without previously
building the managed tests ends up failing the build due to
unrestored packages. This was due to the fact that I overlooked
that CopyDependenciesToCoreRoot needs the support projects to be
restored; in usual scenarios, they usually got restored as part
of another build step like managed test build so that I didn't hit
that in my local and lab testing.
Thanks
Tomas
/cc @dotnet/runtime-infrastructure