Skip to content

Test fix: FileStream DeleteOnClose run on OuterLoop with longer timeout #60149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 1 commit into from
Oct 14, 2021
Merged

Test fix: FileStream DeleteOnClose run on OuterLoop with longer timeout #60149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/libraries/System.IO.FileSystem/tests/FileStream/DeleteOnClose.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ namespace System.IO.Tests
public class FileStream_DeleteOnClose : FileSystemTest
{
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsFileLockingEnabled), nameof(PlatformDetection.IsThreadingSupported))]
[OuterLoop]
public async Task OpenOrCreate_DeleteOnClose_UsableAsMutex()
{
var cts = new CancellationTokenSource();
Expand Down Expand Up @@ -69,7 +70,7 @@ public async Task OpenOrCreate_DeleteOnClose_UsableAsMutex()
}

// Wait for 1000 locks.
cts.CancelAfter(TimeSpan.FromSeconds(60)); // Test timeout.
cts.CancelAfter(TimeSpan.FromSeconds(120)); // Test timeout (reason for outerloop)
Copy link
Contributor Author

@carlossanlop carlossanlop Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmds I'd like to assume this is the timeout you wanted me to extend? I ask because there are 3 Task.Delay calls above. Should I extend those as well? I wonder if 1 ms delays are long enough.

Copy link
Member

@tmds tmds Oct 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the one.

Copy link
Member

@adamsitnik adamsitnik Oct 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the one.

For some reason when I read it I hear:

image

Volatile.Write(ref locksRemaining, 500);
await Task.WhenAll(tasks);

Expand Down