Don't error out from GetOrCreateLayout in the DAC if no layout creation is needed #60401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @tommcdon Issue DetailsFixes #60321 Before #59590, DAC paths used to only fall on paths where we This was also seen up stack in WinForms as a failure to start up the debugger.
|
Member
Author
|
cc: @RussKie |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60321
Before #59590, DAC paths used to only fall on paths where we
had loaded image layouts. The cleanup changed Get calls to GetOrCreate
ones which error out in the DAC always, even if the get is successful.
Simply have the DAC return on the successful get, and error if creation
was necessary.
This was also seen up stack in WinForms as a failure to start up the debugger.
The previous code technically had an AV risk, this also prevents that.