-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Fix double expansion of AggregateException.Flatten message #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks, it would be good to review the test PR before merging this. (We are very close to being able to have a corelib change and its tests in the same PR, finally enabled by the repo consolidation...) |
|
The test changes are visible from the previous #133 PR (which was already approved). If I created the tests PR now it would just fail. |
96372f3 to
46c47f2
Compare
|
The build failures look unrelated - every PR has this Windows_NT arm checked build failing. |
|
/azp run runtime-libraries |
|
Commenter does not have sufficient privileges for PR 605 in repo dotnet/runtime |
|
triggering CI again -- BTW to do this yourself, since you don't have the power to do /azp commands unfortunately, it's easiest to do git commit --amend add a space to the description and thus force a new SHA, then push that. |
46c47f2 to
4667146
Compare
|
It seems that just closing/re-opening didn't clear the ARM test results, so I force pushed the commit with an amended message as you recommended. |
4e2bce2 to
5b69404
Compare
5b69404 to
da354bd
Compare
|
It feels like it's impossible to get the CI green - every time some random part of it falls apart with helpful errors like: |
da354bd to
6bff61f
Compare
stephentoub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Re-created from #133 without updating tests as live built dependencies are still not available.
Will create a separate PR for adding test coverage.