Skip to content

Conversation

@pentp
Copy link
Contributor

@pentp pentp commented Dec 6, 2019

Re-created from #133 without updating tests as live built dependencies are still not available.
Will create a separate PR for adding test coverage.

@danmoseley
Copy link
Member

Thanks, it would be good to review the test PR before merging this. (We are very close to being able to have a corelib change and its tests in the same PR, finally enabled by the repo consolidation...)

@pentp
Copy link
Contributor Author

pentp commented Dec 6, 2019

The test changes are visible from the previous #133 PR (which was already approved). If I created the tests PR now it would just fail.

@pentp
Copy link
Contributor Author

pentp commented Dec 23, 2019

The build failures look unrelated - every PR has this Windows_NT arm checked build failing.

@pentp
Copy link
Contributor Author

pentp commented Jan 14, 2020

/azp run runtime-libraries

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 605 in repo dotnet/runtime

@danmoseley danmoseley closed this Jan 14, 2020
@danmoseley danmoseley reopened this Jan 14, 2020
@danmoseley
Copy link
Member

triggering CI again -- BTW to do this yourself, since you don't have the power to do /azp commands unfortunately, it's easiest to do git commit --amend add a space to the description and thus force a new SHA, then push that.

@pentp
Copy link
Contributor Author

pentp commented Jan 14, 2020

It seems that just closing/re-opening didn't clear the ARM test results, so I force pushed the commit with an amended message as you recommended.

@pentp pentp force-pushed the fix-flatten-msg branch 2 times, most recently from 4e2bce2 to 5b69404 Compare January 20, 2020 11:06
@pentp
Copy link
Contributor Author

pentp commented Jan 23, 2020

It feels like it's impossible to get the CI green - every time some random part of it falls apart with helpful errors like:

exec failed: container_linux.go:344: starting container process caused "process_linux.go:95: adding pid 38211 to cgroups caused \"failed to write 38211 to cgroup.procs: write /sys/fs/cgroup/cpu,cpuacct/docker/57ef0fb8bcbc2e410ee9bf48b611a08ec104e0656c578e6c2b8195d1dd3401eb/cgroup.procs: invalid argument\"": unknown

The job running on agent NetCorePublic-Pool 59 ran longer than the maximum time of 60 minutes.

// Helix "Failure logs" that contain zero errors...

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@stephentoub stephentoub merged commit e041241 into dotnet:master Jan 29, 2020
@pentp pentp deleted the fix-flatten-msg branch January 29, 2020 20:01
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants