Skip to content

Conversation

@vcsjones
Copy link
Member

Extract a common ECAlgorithm base type from ECDsa and ECDiffieHellman.

Starting as draft to get feedback from CI, then will fill in XML doc comments that are missing.

Closes #61516

@ghost
Copy link

ghost commented Nov 17, 2021

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added area-System.Security new-api-needs-documentation community-contribution Indicates that the PR has been added by a community member labels Nov 17, 2021
@ghost
Copy link

ghost commented Nov 17, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

Extract a common ECAlgorithm base type from ECDsa and ECDiffieHellman.

Starting as draft to get feedback from CI, then will fill in XML doc comments that are missing.

Closes #61516

Author: vcsjones
Assignees: -
Labels:

area-System.Security, new-api-needs-documentation

Milestone: -

@vcsjones vcsjones marked this pull request as ready for review November 18, 2021 17:43
@bartonjs
Copy link
Member

The test that "failed" actually passed, then failed in infra post-testing:

[23:08:46] info: === TEST EXECUTION SUMMARY ===
[23:08:46] info: Total: 264, Errors: 0, Failed: 0, Skipped: 0, Time: 34.89062s

@bartonjs bartonjs merged commit 38ccd84 into dotnet:main Nov 22, 2021
@vcsjones vcsjones deleted the ecalgorithm branch November 22, 2021 21:44
@ghost ghost locked as resolved and limited conversation to collaborators Dec 23, 2021
@bartonjs bartonjs added the needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration label Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Security community-contribution Indicates that the PR has been added by a community member needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration new-api-needs-documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Introduce a common base type for ECDsa and ECDiffieHellman

2 participants