Skip to content

Fix superpmi.py collect script #62347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BruceForstall merged 1 commit into from
Dec 3, 2021
Merged

Fix superpmi.py collect script #62347

BruceForstall merged 1 commit into from
Dec 3, 2021

Conversation

@BruceForstall
Copy link
Contributor

@BruceForstall BruceForstall commented Dec 3, 2021

Collect also does a replay, so needs all the replay arguments set to something.
Fixes this error: 'CoreclrArguments' object has no attribute 'compile'

@BruceForstall
Fix superpmi.py collect script
7be0b9a 
Collect also does a replay, so needs all the replay arguments set to something.
Fixes this error: `'CoreclrArguments' object has no attribute 'compile'`
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 3, 2021
@ghost
Copy link

ghost commented Dec 3, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Collect also does a replay, so needs all the replay arguments set to something.
Fixes this error: 'CoreclrArguments' object has no attribute 'compile'

Author: BruceForstall
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@BruceForstall
Copy link
Contributor Author

BruceForstall commented Dec 3, 2021

fyi @SeanWoo -- regression from #62217. There's an unfortunately subtle issue with argument processing for superpmi.py collect.

@BruceForstall
Copy link
Contributor Author

BruceForstall commented Dec 3, 2021

@kunalspathak @dotnet/jit-contrib PTAL

kunalspathak
kunalspathak approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BruceForstall BruceForstall merged commit 62b2333 into dotnet:main Dec 3, 2021
@BruceForstall BruceForstall deleted the FixSpmiScript branch December 3, 2021 22:45
@ghost ghost locked as resolved and limited conversation to collaborators Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kunalspathak kunalspathak kunalspathak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BruceForstall @kunalspathak