Skip to content

Revert "[mono][wasm] Fix the passing/returning of small vtypes. (#622… #62380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vargaz wants to merge 2 commits into from
Closed

Revert "[mono][wasm] Fix the passing/returning of small vtypes. (#622… #62380

vargaz wants to merge 2 commits into from

Conversation

@vargaz
Copy link
Contributor

@vargaz vargaz commented Dec 4, 2021

…99)"

This reverts commit 915ee6d.

This causes test failures in the System.Collections.Immutable testsuite on wasm.

@agocke
Copy link
Member

agocke commented Dec 4, 2021

/azp run runtime-manual

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 4, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz vargaz requested a review from radical December 4, 2021 13:27
@vargaz vargaz added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Dec 4, 2021
@vargaz vargaz marked this pull request as draft December 4, 2021 16:27
@radical
Copy link
Member

radical commented Dec 4, 2021

If this fixes System.Collections.Immutable tests, then this should be removed - https://github.com/dotnet/runtime/blob/main/src/libraries/tests.proj#L25

@vargaz
Copy link
Contributor Author

vargaz commented Dec 4, 2021

/azp run runtime-manual

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 4, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz vargaz mentioned this pull request Dec 4, 2021
Merged
vargaz added 2 commits December 4, 2021 20:24
@vargaz
Revert "[mono][wasm] Fix the passing/returning of small vtypes. (dotn…
a202b89 
…et#62299)"

This reverts commit 915ee6d.

This causes test failures in the System.Collections.Immutable testsuite on wasm.
@vargaz
Reenable tests.
8f3e016
@vargaz
Copy link
Contributor Author

vargaz commented Dec 5, 2021

/azp run runtime-manual

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 5, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz vargaz marked this pull request as ready for review December 5, 2021 12:32
@vargaz
Copy link
Contributor Author

vargaz commented Dec 6, 2021

Closing in favor of:
#62400

@vargaz vargaz closed this Dec 6, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageek lambdageek lambdageek approved these changes

@EgorBo EgorBo Awaiting requested review from EgorBo

@imhameed imhameed Awaiting requested review from imhameed

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

@radical radical Awaiting requested review from radical

Assignees

No one assigned

Labels

area-Codegen-LLVM-mono NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vargaz @agocke @radical @lambdageek