Skip to content

[wasm] benchmark sample modularized #62395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pavelsavara merged 3 commits into from
Dec 6, 2021
Merged

[wasm] benchmark sample modularized #62395

pavelsavara merged 3 commits into from
Dec 6, 2021

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Dec 4, 2021 •
edited
Loading

  • Silence the errors just before we abort the iframe, because there all fetch promises in flight would be aborted inside the iframe and the errors would be printed
  • Make benchmark more readable, separate the application in the iframe
  • bind console.log and console.error as Kate suggested
  • use Module.printErr to report all errors

Fixes #62357

@ghost
Copy link

ghost commented Dec 4, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Make it more readable

Author: pavelsavara
Assignees: -
Labels:

area-Infrastructure-mono
Milestone: -

@pavelsavara pavelsavara requested review from kg and radekdoulik December 4, 2021 16:55
@pavelsavara pavelsavara marked this pull request as ready for review December 4, 2021 17:00
@pavelsavara pavelsavara mentioned this pull request Dec 4, 2021
Closed
kg
kg previously requested changes Dec 4, 2021
View reviewed changes
Copy link
Member

@kg kg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall but there are parts of this I'm not familiar with

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Dec 4, 2021
@radical radical added the arch-wasm WebAssembly architecture label Dec 5, 2021
@ghost
Copy link

ghost commented Dec 5, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Silence the errors just before we abort the iframe, because there all fetch promises in flight would be aborted inside the iframe and the errors would be printed
  • Make benchmark more readable, separate the application in the iframe
  • bind console.log and console.error as Kate suggested
  • use Module.printErr to report all errors

Fixes #62357

Author: pavelsavara
Assignees: -
Labels:

arch-wasm, area-Infrastructure-mono, needs-author-action
Milestone: -

@pavelsavara pavelsavara force-pushed the wasm_benchmark_sample branch from 3c1be5a to b9454b7 Compare December 5, 2021 12:09
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Dec 5, 2021
@pavelsavara pavelsavara requested a review from kg December 5, 2021 12:25
radekdoulik
radekdoulik reviewed Dec 6, 2021
View reviewed changes
radekdoulik
radekdoulik approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@radekdoulik radekdoulik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the done event it LGTM.

@pavelsavara @radekdoulik
no need for "done"
2b6e9ce 
Co-authored-by: Radek Doulik <radek.doulik@gmail.com>
@pavelsavara pavelsavara dismissed kg’s stale review December 6, 2021 12:05

I fixed the comment and we discussed it on Discord

@pavelsavara pavelsavara merged commit 1872ef5 into dotnet:main Dec 6, 2021
@pavelsavara pavelsavara deleted the wasm_benchmark_sample branch January 4, 2022 13:06
@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radekdoulik radekdoulik radekdoulik approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@kg kg Awaiting requested review from kg

Assignees

No one assigned

Labels

arch-wasm WebAssembly architecture area-Infrastructure-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[wasm] browser-bench appstart is broken on main

4 participants

@pavelsavara @kg @radekdoulik @radical