Remove obsolete tests from System.Net.Security #624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests haven't been running nor even compiling for several years. The compilation broke when CSPROJ changes were made regarding TargetsLinux vs. TargetsUnix. The tests themselves required running in admin mode and made impactful changes on the host machine (such as installing a KDC). Now that enterprise scenario tests have been added with PR dotnet#463, these tests are no longer needed. Much of these tests have already been incorporated into the new enterprise tests. Closes https://github.com/dotnet/corefx/issues/30150 Closes https://github.com/dotnet/corefx/issues/24707
davidsh
added
area-System.Net.Security
test-enhancement
stephentoub
approved these changes
Dec 6, 2019
Contributor
Author
|
I'm excited to see that the Azure pipeline for enterprise scenario testing is now running automatically for PRs!!
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests haven't been running nor even compiling for several years. The compilation
broke when CSPROJ changes were made regarding TargetsLinux vs. TargetsUnix.
The tests themselves required running in admin mode and made impactful changes on the
host machine (such as installing a KDC).
Now that enterprise scenario tests have been added with PR #463, these tests are no longer
needed. Much of these tests have already been incorporated into the new enterprise
tests.
Closes https://github.com/dotnet/corefx/issues/30150
Closes https://github.com/dotnet/corefx/issues/24707